Skip to content

Remove the --fix flag from the pre-commit rumdl hook#857

Merged
5ouma merged 1 commit intomainfrom
fix-pre-commit-rumdl-fix
Apr 5, 2026
Merged

Remove the --fix flag from the pre-commit rumdl hook#857
5ouma merged 1 commit intomainfrom
fix-pre-commit-rumdl-fix

Conversation

@5ouma
Copy link
Copy Markdown
Owner

@5ouma 5ouma commented Apr 5, 2026

It's set by default from the latest version.

It's set by default from the latest version.
Copilot AI review requested due to automatic review settings April 5, 2026 11:27
@github-actions github-actions bot added the 🚸 pre-commit Check the code with pre-commit hooks label Apr 5, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s pre-commit configuration to align with the latest rumdl hook behavior, removing an explicit flag that is now enabled by default upstream.

Changes:

  • Removed the explicit --fix argument from the rumdl pre-commit hook args list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6e363e68-01b3-4e80-a45a-48972c815a1d

📥 Commits

Reviewing files that changed from the base of the PR and between d423bbd and 824c89f.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Walkthrough

Modified the rumdl pre-commit hook configuration in .pre-commit-config.yaml by removing the --fix argument. The hook will now run without automatic fixes while retaining existing --fail-on warning and --disable options.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Removed --fix argument from rumdl hook args list; --fail-on warning and --disable "MD013,MD024,MD033,MD036" options preserved.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing the --fix flag from the pre-commit rumdl hook configuration.
Description check ✅ Passed The description explains the rationale for the change, indicating that the --fix flag is set by default in the latest version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pre-commit-rumdl-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@5ouma 5ouma merged commit 1b3ed66 into main Apr 5, 2026
9 checks passed
@5ouma 5ouma deleted the fix-pre-commit-rumdl-fix branch April 5, 2026 11:31
@5ouma 5ouma bot mentioned this pull request Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants