Skip to content

Specify Deno command explicitly#957

Merged
5ouma merged 2 commits into
mainfrom
fix-pre-commit-git-notion-deno
May 16, 2026
Merged

Specify Deno command explicitly#957
5ouma merged 2 commits into
mainfrom
fix-pre-commit-git-notion-deno

Conversation

@5ouma
Copy link
Copy Markdown
Owner

@5ouma 5ouma commented May 16, 2026

Avoid failing to execute the TypeScript file directly.

Copilot AI review requested due to automatic review settings May 16, 2026 07:16
@github-actions github-actions Bot added the 🚸 pre-commit Check the code with pre-commit hooks label May 16, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

Review Change Stack

Warning

Rate limit exceeded

@5ouma has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 24 minutes and 41 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bfb4e566-8b4e-4a55-9f96-c925e040a6dc

📥 Commits

Reviewing files that changed from the base of the PR and between 22482f8 and a9c0942.

⛔ Files ignored due to path filters (1)
  • pre-commit/hooks/upload-git-commit-notion/deno.lock is excluded by !**/*.lock
📒 Files selected for processing (5)
  • .github/renovate.json
  • .github/workflows/ci.yml
  • .pre-commit-hooks.yaml
  • pre-commit/hooks/upload-git-commit-notion.ts
  • pre-commit/hooks/upload-git-commit-notion/deno.json

Walkthrough

The PR refactors how the upload-git-commit-notion pre-commit hook executes its TypeScript entrypoint. The hook configuration now explicitly invokes Deno via deno run -P, while the script's shebang line is removed, consolidating runtime invocation into the hook declaration rather than relying on script-level execution directives.

Changes

Deno Execution Model

Layer / File(s) Summary
Hook invocation and shebang refactor
.pre-commit-hooks.yaml, pre-commit/hooks/upload-git-commit-notion/main.ts
The hook entry command changes to deno run -P .../main.ts, and the corresponding shebang #!/usr/bin/env -S deno run -P is removed from the TypeScript file. Runtime invocation responsibility moves from the script declaration to the pre-commit hook configuration.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Specify Deno command explicitly' accurately describes the main change of the pull request.
Description check ✅ Passed The description is related to the changeset, explaining the motivation for specifying Deno command explicitly to avoid execution failures.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-pre-commit-git-notion-deno

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 16, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the published pre-commit hook definition to invoke the Deno runtime explicitly rather than relying on executing the TypeScript file directly (via a shebang), reducing the chance of execution failures in environments that don’t execute .ts files as programs.

Changes:

  • Remove the Deno shebang from the hook’s main.ts.
  • Update .pre-commit-hooks.yaml so the hook entry runs deno run -P ... explicitly.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pre-commit/hooks/upload-git-commit-notion/main.ts Removes the shebang so the script is no longer expected to be executed directly.
.pre-commit-hooks.yaml Updates the hook entry to explicitly execute the TypeScript file via deno run -P.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@5ouma 5ouma force-pushed the fix-pre-commit-git-notion-deno branch 4 times, most recently from 9f8a1cd to 4635456 Compare May 16, 2026 07:48
5ouma added 2 commits May 16, 2026 16:51
Avoid failing to execute the TypeScript file directly.
The root project is the hooks directory.
@5ouma 5ouma force-pushed the fix-pre-commit-git-notion-deno branch from 4635456 to a9c0942 Compare May 16, 2026 07:51
@5ouma
Copy link
Copy Markdown
Owner Author

5ouma commented May 16, 2026

@coderabbitai approve

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 16, 2026

✅ Actions performed

Comments resolved and changes approved.

@5ouma 5ouma merged commit a36fe4a into main May 16, 2026
9 checks passed
@5ouma 5ouma deleted the fix-pre-commit-git-notion-deno branch May 16, 2026 08:18
@5ouma 5ouma Bot mentioned this pull request May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🚸 pre-commit Check the code with pre-commit hooks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants