-
-
Notifications
You must be signed in to change notification settings - Fork 8
[API] Match state transition allows skipping veto, checkIntoMatch hardcoded false, fragment NaN #380
Copy link
Copy link
Open
5stackgg/api
#136Labels
P2-mediumCode quality & robustnessCode quality & robustnessaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditlogic-errorLogic or state machine bugLogic or state machine bugservice:api5stackgg/api service5stackgg/api service
Description
Summary
Several logic errors in match flow control and API responses.
Findings
- matches.controller.ts — condition uses
||instead of&&, allowing match start during Veto. - matches.controller.ts —
checkIntoMatchreturnssuccess: falsealways, regardless of actual result. - match-relay.controller.ts —
parseInt(fragment)with no validation (could be NaN, negative, or huge).
Impact
Matches could skip veto. Clients can never confirm check-in success. Fragment parsing could cause logic errors.
Suggested Fix
Fix boolean operator. Return actual success status. Validate parseInt with bounds checking.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P2-mediumCode quality & robustnessCode quality & robustnessaudit-2026-03From March 2026 codebase auditFrom March 2026 codebase auditlogic-errorLogic or state machine bugLogic or state machine bugservice:api5stackgg/api service5stackgg/api service
Type
Projects
Status
In progress