[Game Server] Resource disposal — HttpClient, WebSocket, Timer, pending messages accumulation

[Flegma]

Summary

Multiple resource types created without proper disposal, causing leaks over plugin lifetime.

Findings

• MatchService.cs — new HttpClient() without using or DI. Should be singleton/injected.
• MatchEvents.cs — WebSocket set to null without Dispose(). New WebSocket not disposed if ConnectAsync throws.
• ReadySystem.cs — timer references lost when Reset() called with setupTimer=true multiple times.
• SurrenderSystem.cs — _disconnectTimers accumulates in TimerUtility.Timers static list. Only cleared at match end.
• MatchEvents.cs — System.Timers.Timer _retryTimer never disposed on plugin Unload.
• MatchEvents.cs — _pendingMessages grows indefinitely if server stops acknowledging. No max size or TTL.

Impact

Memory and connection exhaustion over extended uptime. Timer list grows unbounded.

Suggested Fix

Use DI or static HttpClient. Add Dispose() in try/finally. Kill timers before creating new. Cap pending messages.

---

Related Issues (Memory Leak Pattern)

• [API] Missing NestJS lifecycle cleanup — intervals, recursive timeouts, stale WS refs #375 — [API] Missing NestJS lifecycle cleanup
• [Web] GraphQL subscription leaks — NotificationStore, ApplicationSettings, Matchmaking, MatchLobby #385 — [Web] GraphQL subscription leaks
• [Web] Socket listeners & component event handlers never cleaned up #386 — [Web] Socket listeners never cleaned up
• [Game Server] Resource disposal — HttpClient, WebSocket, Timer, pending messages accumulation #398 — [Game Server] Resource disposal issues
• [Connector] Network monitoring process leak & throttle instance accumulation #407 — [Connector] Network process leak & throttle accumulation