Skip to content

fix: prevent unauthorized match winner setting and add state validation #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukepolo merged 3 commits into from
Mar 8, 2026
Merged

fix: prevent unauthorized match winner setting and add state validation #112

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c5ae53
fix: prevent unauthorized match winner setting and add state validation
Flegma Mar 6, 2026
6ec1a4d
refactor: extract shared terminal match status constants
Flegma Mar 6, 2026
bc6fc9e
fix: allow setting match winner in any state
Flegma Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions src/matches/matches.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,14 @@ import { MatchRelayService } from "./match-relay/match-relay.service";
export class MatchesController {
private readonly appConfig: AppConfig;

private static readonly TERMINAL_STATUSES: string[] = [
"Finished",
"Canceled",
"Forfeit",
"Tie",
"Surrendered",
];

constructor(
private readonly logger: Logger,
private readonly hasura: HasuraService,
Expand Down Expand Up @@ -187,13 +195,7 @@ export class MatchesController {
throw Error("unable to find match");
}

if (
matches_by_pk.status === "Tie" ||
matches_by_pk.status === "Canceled" ||
matches_by_pk.status === "Forfeit" ||
matches_by_pk.status === "Finished" ||
matches_by_pk.status === "Surrendered"
) {
if (MatchesController.TERMINAL_STATUSES.includes(matches_by_pk.status)) {
response.status(204).end();
return;
}
Expand Down Expand Up @@ -330,11 +332,7 @@ export class MatchesController {
*/
if (
data.op === "DELETE" ||
status === "Tie" ||
status === "Forfeit" ||
status === "Canceled" ||
status === "Finished" ||
status === "Surrendered"
MatchesController.TERMINAL_STATUSES.includes(status)
) {
this.matchRelayService.removeBroadcast(matchId);
await this.removeDiscordIntegration(matchId);
Expand Down Expand Up @@ -606,7 +604,7 @@ export class MatchesController {
}) {
const { match_id, user, winning_lineup_id } = data;

if (await this.matchAssistant.isOrganizer(match_id, user)) {
if (!(await this.matchAssistant.isOrganizer(match_id, user))) {
throw Error("you are not a match organizer");
}

Expand Down Expand Up @@ -641,10 +639,27 @@ export class MatchesController {
}) {
const { match_id, user, winning_lineup_id } = data;

if (await this.matchAssistant.isOrganizer(match_id, user)) {
if (!(await this.matchAssistant.isOrganizer(match_id, user))) {
throw Error("you are not a match organizer");
}

const { matches_by_pk: matchToForfeit } = await this.hasura.query({
matches_by_pk: {
__args: {
id: match_id,
},
status: true,
},
});

if (!matchToForfeit) {
throw Error("match not found");
}

if (MatchesController.TERMINAL_STATUSES.includes(matchToForfeit.status)) {
throw Error("cannot forfeit a match that has already ended");
}

const { update_matches_by_pk: match } = await this.hasura.mutation({
update_matches_by_pk: {
__args: {
Expand Down