Implement surround mode

[ChrHorn]

A dedicated mode that deals with surrounds would be very useful. Commands like:

• surround a selection with matching parentheses, brackets or quotes
• change an existing surround
• delete an existing surround

Analogous to the existing Kakoune extension.

[71]

It certainly could be useful, but for now it's very low priority. You're welcome to take a shot at it if you want, though!

[pomdtr]

The kakoune mirror plugin could be easier to implement, and is a better option in my opinion : https://github.com/Delapouite/kakoune-mirror

[tshort]

Would be cool to have a way to implement it as easily as kakoune-mirror (only 38 lines).

[tshort]

Here's an implementation of kakoune-mirror for Dance:

https://gist.github.com/tshort/7dc4457e01935e917536f32eb104a16d

It uses the multi-command extension. I really like how this works.

[pomdtr]

Alternative surround implementation using the around extension, trying to mimic the vim-surround extension

    "dance.menus": {
        "surround": {
            "items": {
                "a": {
                    "text": "add surround",
                    "command": "extension.around",
                },
                "c": {
                    "text": "replace surround",
                    "command": "multiCommand.mirror.c",
                },
                "d": {
                    "text": "delete surround",
                    "command": "multiCommand.mirror.d",
                },
            }
},
    "multiCommand.commands": [
        {
            "command": "multiCommand.mirror.c",
            "sequence": [
                "dance.marks.saveSelections",
                "dance.select.firstLast",
                "dance.delete.noYank",
                "dance.marks.restoreSelections",
                "extension.around",
            ]
        },
        {
            "command": "multiCommand.mirror.d",
            "sequence": [
                "dance.marks.saveSelections",
                "dance.select.firstLast",
                "dance.delete.noYank",
                "dance.marks.restoreSelections",
            ]
        },
    ],

[71]

Adding support for multi commands should be fairly simple, if don't want to install other extensions.

All your examples makes me think we should have a "Recipes" Markdown file for all those things we can do.

[EdAyers]

Here's an implementation of kakoune-mirror for Dance:

https://gist.github.com/tshort/7dc4457e01935e917536f32eb104a16d

I love this snippet. But note that it is now out of date and won't work. To fix, change "menu" to "input" in keybindings.json.

Edit: oops no it's still broken, I've tried to repair it to use the new commands but I can't find the new name for "dance.select.firstLast".

[71]

Dance also supports multi-commands out of the box with dance.run, so the snippet could be shorter with no external dependencies.

As for dance.select.firstLast, it is now called dance.selections.reduce.edges (which is itself an alias for dance.selections.reduce with the arguments { where: "both", empty: false }).

[EdAyers]

Nice thanks, here's an updated gist. https://gist.github.com/EdAyers/bc018025912b2315d244f28d707a0462

[71]

I've added my kakoune-mirror implementation to the wiki. This version requires the latest commits to Dance, but no longer switches modes temporarily when making edits (thus making commands much faster).