Skip to content
This repository was archived by the owner on Feb 18, 2022. It is now read-only.

Conversation

@gtmsingh
Copy link
Contributor

Whenever user clicks on dropdown to see the years he can select, even after choosing a particular year the year's dropdown does not goes away. I have set $scope.showYearsPagination to false whenever any valid date is set.

@wouldgo
Copy link
Member

wouldgo commented Oct 13, 2015

Hi @gtmsingh,

I see only the whole indentation lost. What's the actual piece of code modified?
I'm sorry but right now imho this isn't lgtm.

Thanks for your time we're open for discussion.
Dario

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the only line that I added.

@gtmsingh
Copy link
Contributor Author

It was fault in my editors plugin that the whole indentation was lost. If you want the older indentation I can revert back and send you another pull request. I have commented at the line which I added. I am very new to open source contribution. If possible, can you walk me through how should I proceed with my work so that it looks structured when I send pull requests

Thanks

@wouldgo
Copy link
Member

wouldgo commented Oct 31, 2015

Hi @gtmsingh,

I'm really sorry for not responding you. Anyway yes, if you can revert the previous indentation and re-submit your contribution we really appreciated.

Have a great day
Dario.

@gtmsingh
Copy link
Contributor Author

gtmsingh commented Nov 2, 2015

Hi @wouldgo,
I have tried my best to reindent the code as it was. Please check the diff and let me know if the only indentation which is not done is required or not. I don't find the reason it shows diff at that line.

Thanks!
Gautam

wouldgo added a commit that referenced this pull request Nov 3, 2015
Autoclose year dropdown on selection of valid year
@wouldgo wouldgo merged commit b189e35 into 720kb:master Nov 3, 2015
@wouldgo
Copy link
Member

wouldgo commented Nov 3, 2015

Hi @gtmsingh,

thanks a lot for the effort in rolling back all the indentation and for contribution! 👍
As soon as possible we'll publish a new version.

Best regards,
Dario

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants