-
Notifications
You must be signed in to change notification settings - Fork 328
Autoclose year dropdown on selection of valid year #100
Conversation
|
Hi @gtmsingh, I see only the whole indentation lost. What's the actual piece of code modified? Thanks for your time we're open for discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the only line that I added.
|
It was fault in my editors plugin that the whole indentation was lost. If you want the older indentation I can revert back and send you another pull request. I have commented at the line which I added. I am very new to open source contribution. If possible, can you walk me through how should I proceed with my work so that it looks structured when I send pull requests Thanks |
|
Hi @gtmsingh, I'm really sorry for not responding you. Anyway yes, if you can revert the previous indentation and re-submit your contribution we really appreciated. Have a great day |
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
…-datepicker into autoclose-year-dropdown
|
Hi @wouldgo, Thanks! |
Autoclose year dropdown on selection of valid year
|
Hi @gtmsingh, thanks a lot for the effort in rolling back all the indentation and for contribution! 👍 Best regards, |
Whenever user clicks on dropdown to see the years he can select, even after choosing a particular year the year's dropdown does not goes away. I have set
$scope.showYearsPaginationtofalsewhenever any valid date is set.