This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Setting selected date on first time showCalendar() call #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When datepicker opens first time, the selectedDay, selectedMonth and selectedYear are not initialised, which prevent the active class from being applied. This works on subsequent opens though once setDatepickerDay is called.
tipycalFlow
changed the title
Member
|
legit @tipycalFlow thanks. See my comments, be sure to not skip linter on every commit please 👍 |
45kb
suggested changes
Jan 19, 2017
src/js/angular-datepicker.js
Outdated
|
|
||
| theCalendar.classList.add('_720kb-datepicker-open'); | ||
| var dateString = angular.element((angular.element(theCalendar).parent()[0]).querySelector('input')).val(); | ||
| var date = new Date(dateString); |
Member
There was a problem hiding this comment.
Please run the linter task do not skip it, i am quite sure you'll have to combine these global vars with the upper ones (see linter errors) :)
var dateString = ...
, date = ....
;```
Contributor
Author
|
@45kb please check now |
45kb
approved these changes
Jan 19, 2017
Member
|
@tipycalFlow awesome, tested this deeply? :) |
Contributor
Author
|
Needs changes for safari (getting invalid date when parsing) |
Member
|
@tipycalFlow ok i reverted the PR please send a new one ;) , give it a try on IE if you can. Also be sure to run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When datepicker opens first time, the
selectedDay,selectedMonthandselectedYearare not initialised, which prevent the active class from being applied. This works on subsequent opens though, oncesetDatepickerDayhas been called.