This repository was archived by the owner on Nov 17, 2025. It is now read-only.
Lazy calculating position #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@psdcoder thank you a lot, have you just tested out (better in all browsers) if any tooltip delay or flashes with the "lazy-mode"? Cause lazy-mode implies the tooltip is executed only at the event fired... 🎱 :) |
Member
|
Tested on Safari, Chrome, Firefox it's everything ok :) thank you a lot 👍 |
Contributor
Author
|
No any flashes, because first we calculate position and then add showing class. You're welcome) |
Member
|
awesome job! thank you :) |
Contributor
Author
|
Oh, one question) When will be new version for bower? |
Member
|
@psdcoder 5 min :) |
Member
|
https://github.com/720kb/angular-tooltips/releases/tag/0.1.2 done, also updated bower, new version includes your changes plus new attributes https://github.com/720kb/angular-tooltips#tooltip-event-triggers |
Contributor
Author
|
Thanks a lot) |
Member
|
👍 |
45kb
pushed a commit
that referenced
this pull request
May 28, 2015
empty text doesn't make popup disablear
wouldgo
added a commit
that referenced
this pull request
Nov 9, 2015
wouldgo
added a commit
that referenced
this pull request
Nov 30, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had some issues with calculating position of tooltip, so I decide do it only when user uses this tooltip. Also it's decrease manipulations with dom (user even can don't use tooltip, but without lazy calculating we always calculate position of tooltip). Also I added "main" section to bower.json for correct work of wiredep plugins in grunt/gulp/etc.