-
Notifications
You must be signed in to change notification settings - Fork 0
move save buttons to match rebels page #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR moves save buttons to the header area of various manager components to match the UI pattern established in the rebels page, improving consistency across the application.
Key changes:
- Relocates save buttons from bottom/inline positions to the header area alongside edit buttons
- Adds consistent spacing and layout improvements across manager components
- Resets selection states when canceling or toggling edit mode
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| app/tailwind.css | Adds fieldset padding override for consistent spacing |
| app/components/VillainManager/index.tsx | Moves save button to header, adds selection state reset, improves spacing |
| app/components/RebelSummaryManager/index.tsx | Minor spacing adjustment for consistency |
| app/components/RebelRewardManager/index.tsx | Adds selection state reset functionality |
| app/components/RebelClassManager/index.tsx | Reduces padding and improves text color consistency |
| app/components/ImperialRewardManager/index.tsx | Moves save button to header, adds sorting, removes disabled state from dropdown |
| app/components/ImperialClassManager/index.tsx | Moves save button to header, improves spacing and cursor styling |
| app/components/AllyManager/index.tsx | Adds selection state reset functionality |
| app/components/AgendaManager/index.tsx | Moves save button to header, improves layout structure |
closes #4