Self-host Prettier via root package.json; drop creyD/prettier_action#122
Merged
Conversation
Replaces the third-party Prettier action with a locally-pinned prettier devDep in a new root package.json. Now: - prettier version is locked in package-lock.json (no surprise reformats when the action's version-pinning bug bites again) - both devs can run `npm run format` / `npm run format:check` locally with the same version CI uses - workflow is a straight `npm ci && npm run format:check` Includes the one-time Prettier 3 reformat (trailing-commas-all is the v3 default; touches 11 files, formatting only — verified by diff that no semantics changed). Client builds; pre-existing /adr + /rosterstatistics prerender errors unchanged. This implicitly resolves the creyD/prettier_action portion of #117 since the action is no longer referenced. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
creyD/prettier_action@v4.6silently broke theprettier_versioninput — instead of installing the pinned version, it falls back to whatever current is on npm (3.8.3 today). That's how the lint job blew up when Dependabot bumped the action (we reverted back to v4.3 to fix it). We're one shaky third-party update away from this recurring.This PR removes that fragility by pinning Prettier in our own lockfile and dropping the third-party action.
What changed
package.jsonwithprettieras a single devDep +format/format:checkscripts.prettierignorecovering build outputs and lockfilescreyD/prettier_action@v4.3→npm ci && npm run format:check(withactions/setup-node@v6+ npm cache)trailingComma: "all"default change + long font-family list wrapping inglobals.css. Verified by spot-checking diffs: no semantic changes.Both devs
Local usage is now:
Same Prettier version everywhere, locked in
package-lock.json. Dependabot will propose future Prettier bumps as normal PRs with a visible reformat diff.Implicit resolution
Resolves the
creyD/prettier_action 4.3 → 4.6half of #117 — the action is no longer referenced.Test plan
npm run format:checkclean locallyclient/npm run buildcompiles successfully (pre-existing/adr+/rosterstatisticsprerender errors are unchanged from main)🤖 Generated with Claude Code