-
Notifications
You must be signed in to change notification settings - Fork 0
Command feedback #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Aechylus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non breaking change in general. Though, the more I think about it, the more I'm leaning towards having the messages in TMConstants as a static function instead; that way, we can specify the arguments to the messages explicitly, rather than relying on the %s in the string format. Plus, we can introduce logic in the String generation, i.e. calling helper function addErrorColor() or something like that.
|
Should that be done as part of this PR or after this PR though? |
|
Posting this here from a WA chat for posterity. [3:46 pm, 01/10/2021] Aechylus: We can make it a separate PR if you wanna make the history cleaner and more traceable
Therefore, this'll be a separate issue and PR. |
Added and changed feedback messages according to issue #3 and existing
TODOs.