Merged
Conversation
Contributor
HanYeop
commented
Nov 11, 2023
HanYeop
commented
- 프로필 수정 화면
- 프로필 수정 기능 추가
- 회원가입, 프로필 수정에서 겹치는 로직 리팩토링
SseO-KR
reviewed
Nov 11, 2023
| _editEventFlow.emit(EditEvent.Fail(R.string.message_invalid_nickname)) | ||
| } | ||
| }else{ | ||
| editProfile() |
Member
There was a problem hiding this comment.
nicknameInvalidCheck 함수 내에서 editProfile을 실행하는 방법도 있지만
nicknameInvalidCheck에서 boolean을 return 시켜서 함수 명대로 Check의 역할만 하게 하고
editProfileRequest 함수 내에서 true 시에만 editProfile을 실행시키면 두 함수 간의 결합도를 낮출 수 있지 않을까 합니다
SseO-KR
reviewed
Nov 11, 2023
| class MyPageFragment : BaseFragment<FragmentMyPageBinding>(R.layout.fragment_my_page) { | ||
|
|
||
| private val myPageViewModel by viewModels<MyPageViewModel>() | ||
| private val myPageViewModel by activityViewModels<MyPageViewModel>() |
Member
There was a problem hiding this comment.
navArgs 대신 activityViewModels를 사용한 이유가 뭔가요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.