test: add Tier 1 pure helper tests (fx, envelope, midi, waveform, mixer, piano)#19
Merged
test: add Tier 1 pure helper tests (fx, envelope, midi, waveform, mixer, piano)#19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/audio/domain/fxParams.js— EQ, reverb, maximizer params + soft clip curvesrc/audio/domain/envelope.js— ADSHR envelope scheduling on mock AudioParamsrc/audio/core/getNormalizeGain.js— peak scan, caching, multi-channelsrc/utils/midiPattern.js— drag payload build/parse/round-tripsrc/utils/midiImport.js— MIDI file name detection, ArrayBuffer parsing, DataTransfer helperssrc/utils/patternNotes.js— step/piano note merging and sortingsrc/utils/sampleUrl.js— pack URL encoding and normalizationsrc/components/mixer/mixerUiUtils.js— effect names, insert labels, percent formattingsrc/components/piano-roll/pianoRollUtils.js— pitch/velocity math, quantize, scale stepssrc/components/playlist/playlistWaveformUtils.js— waveform envelope, SVG path, clip window mathAdditional changes
DataTransferglobal mock tosrc/test/setup.jsfor drag-and-drop tests in jsdom.Verification