Skip to content

Collapse fake multi-stage Docker build into single stage#3

Merged
baelter merged 1 commit intomainfrom
claude/review-docker-build-stages-mlbhP
Mar 16, 2026
Merged

Collapse fake multi-stage Docker build into single stage#3
baelter merged 1 commit intomainfrom
claude/review-docker-build-stages-mlbhP

Conversation

@baelter
Copy link
Copy Markdown
Member

@baelter baelter commented Mar 14, 2026

Summary

  • The build stage was the final stage in the Dockerfile, so the multi-stage split was a no-op — all build tools ended up in the published image anyway
  • Merged both stages into a single stage with one combined apt-get install, reducing layers
  • Removed misleading "throw-away build stage" comment

Test plan

  • Verify CI builds succeed for all Ruby versions in the matrix
  • Confirm published image contains both runtime and build packages

https://claude.ai/code/session_01GgxFojxadiw6FgKrketpn3

The "build" stage was the final stage in the Dockerfile, so the
multi-stage split did nothing — all build tools ended up in the
published image anyway. Merge both stages into one and combine
the apt-get installs into a single RUN to reduce layers.

https://claude.ai/code/session_01GgxFojxadiw6FgKrketpn3
@baelter baelter merged commit 55a52af into main Mar 16, 2026
6 checks passed
@baelter baelter deleted the claude/review-docker-build-stages-mlbhP branch March 16, 2026 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants