Raise when sendmsg fails for every resolved address

[oskgu360]

Summary

• Drop the per-packet warn \"Sparoid error: ...\" in sendmsg — hosts with both v4 and v6 addresses on v4-only networks were spamming No route to host even when the other path worked.
• auth now rescues SystemCallError per address, collects the failed-addr error messages, and raises Sparoid::Error only when every address failed.
• auth returns the list of successful addresses so fdpass doesn't try unreachable peers.

Test plan

• bundle exec rake test (23 runs, 42 assertions, 0 failures)
• bundle exec rubocop (clean)
• New tests cover the all-fail (raises) and partial-fail (returns successful addrs, no stderr noise) cases

[oskgu360]

Lazy me didn't wanna go the Bring your own logger path. Just silence the error logs for now :) Tested locally with ssh-monitor

 bundle exec rake dev
bundle exec guard --plugin=foreman --no-interactions --notify false
10:29:08 - INFO - Foreman started.
10:29:08 - INFO - Guard is now watching at '/Users/oskarwestberg/84codes/ssh-monitor'
10:29:08 worker.1 | started with pid 47481
10:29:09 worker.1 | at=info known_hosts written: 139 bytes
10:29:10 worker.1 | at=info HEROKU_API_KEY not set, assuming 1 dyno formation
10:29:10 worker.1 | at=info Test cluster, not posting to PagerDuty: dev-crisp-pink-snake-slow-maintenance Maintenance on dev-crisp-pink-snake is running outside its window
10:29:10 worker.1 | at=info servers#count=2
10:29:10 worker.1 | at=info thread#count=46 alive#count=46 working#count=1 queue#length=1 servers#offline=0
10:29:10 worker.1 | at=info DB store listening to servers.update, servers.insert, clusters.update, accounts.update
10:29:30 worker.1 | at=info servers#count=2

[Copilot]

Pull request overview

This PR adjusts SPA packet sending behavior to avoid noisy per-packet warnings on partial connectivity (e.g., dual-stack hosts on v4-only networks), and instead only raises an error when all resolved destination addresses fail. It also returns only the addresses that successfully received packets so downstream connection logic can skip unreachable peers.

Changes:

• Update Sparoid.auth to rescue SystemCallError per resolved address, collecting failures and raising Sparoid::Error only if every address fails.
• Change Sparoid.auth to return only the subset of addresses that were successfully sent to.
• Remove sendmsg per-packet warning behavior and make socket cleanup resilient when socket creation fails.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/sparoid.rb	Implements per-address failure handling in auth, returns only successful addrs, and removes sendmsg warning behavior while hardening socket close.
test/sparoid_test.rb	Adds tests for “all addresses fail => raises” and “partial failure => returns only successful addrs with no stderr noise”.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[walro]

👍