Skip to content

glsl shaders are applied in incorrect order #3392

@KristopherTadlock

Description

@KristopherTadlock

Opengl 3.0 renderer applies glsl shaders before other screen effects are applied.

In particular this effects the "Force 4:3 display ratio". The shader is applied first, and then the aspect ratio is corrected, causing uneven application of the shader effects.

This namely effects things like scanline generation.

As most software (even the command prompt) will need adjustment to reflect the intended aspect, this means that shaders are only applied correctly in the minority of use cases - largely high resolution SVGA modes which use square pixels.

Incorrect application of the shader causes uneven scanlines
incorrect
86box_incorrect.cfg.txt

Removing other render effects fixes the issue, but now the aspect ratio is no longer correct
correct
86box_correct_wrong_aspect.cfg.txt

Shader used
shader.zip

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions