ESC/P 2: Fix dot size and non-adjacent mode with graphics#6784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The previous code was pretty poor at handling various dot sizes. For instance (ESC * 0x02), 120x60 DPI means dots in diameter of 1/60" are used and head is moved by dot's radius to reach that 120 DPI. Combine it with the wrong assumption that, in non-adjacent mode, dot size is always 1x1 px (so on 360 DPI, 1/360" radius) and you have a recipe for a disaster.
Once fixed, Windows 95 test page looks nice.
Checklist
References
https://files.support.epson.com/pdf/general/escp2ref.pdf