cdrom_image_viso: Fix more non-Windows breakage#7111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The latest VISO commits broke that functionality on Linux.
Commit
198db451achanged VISO root directory stat population to read fromplat_dir_t's current entry instead of callingstat()directly. macOS already exposed the base directory as the initial current entry (viafgetattrlist), but the POSIX backend pre-loaded the first child entry instead, causingplat_dir_is_dir()to return false for the root and aborting the VISO mount.Fix: stat the base directory path before entering the readdir loop and expose it as a synthetic
"."current entry.plat_dir_read()advances past it normally.plat_dir_rewind()andplat_dir_count_children()restore the same state. No change to Windows or macOS backends; no change to callers.Checklist