Conversation
- Changed `backend/models/user.py` to resolve `totp_encryption.key` using an absolute path relative to the `backend` directory. - This prevents "Failed to decrypt TOTP secret" errors when the application is started from different working directories (e.g., project root vs backend root), ensuring consistent key loading. - Added validation when reading the key file to ensure it is a valid Fernet key. - Improved error logging in `_decrypt_totp_secret` to provide specific exception details for debugging.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixed an issue where the TOTP encryption key was being looked up using a relative path, causing decryption failures if the application was started from a directory other than
backend/.The fix ensures
totp_encryption.keyis always resolved relative to thebackenddirectory, regardless of the Current Working Directory (CWD). This restores consistent access to the encryption key and fixes the "Failed to decrypt TOTP secret" error observed during passwordless login.Also added validation to ensure the loaded key is valid and improved error logging for decryption failures.
PR created automatically by Jules for task 2414537731803368346 started by @8JP8