Conversation
…ling 1. **Friend Requests Badge Position:** - Added `relative` class to `FriendRequestsButton` container. This ensures the absolutely positioned notification badge (the red bubble) is anchored to the button itself, not a parent container or the viewport. 2. **VoIP Call Cleanup on Logout:** - Implemented a `useEffect` hook in `VoipContext.tsx` that monitors the `user` state. If the user logs out (user becomes null) while an `activeCall` exists, `leaveCall()` is automatically triggered. This ensures local media streams (microphone/camera) are stopped and WebRTC connections are closed cleanly. 3. **Settings Menu Item Hover Styling:** - Updated the "Settings" link in `UserMenu.tsx`. Previously, it inherited global anchor tag styles (`underline` and blue color on hover). - Added `hover:no-underline` and `hover:theme-text-primary` to the `Link` component. This forces it to behave visually like the other button-based menu items (no underline, consistent text color) while maintaining navigation functionality. Verified with frontend type checks and builds. Visual verification performed where applicable.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
8JP8
deleted the
fix-friend-requests-badge-position-2067340501194718294
branch
1 participant
This PR addresses three distinct user requests:
PR created automatically by Jules for task 2067340501194718294 started by @8JP8