Skip to content

Update 8hobbies/workflows digest to 0addb4a #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renovate merged 1 commit into from
Oct 19, 2025
Merged

Update 8hobbies/workflows digest to 0addb4a #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
lint:
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@35aaff65a539af824d36a72aac42393a71092cc9
uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@0addb4a5f6d2598854f617fae0b907a0ecd34a1e

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 2 months ago

To fix this issue, we should explicitly set the permissions key in the workflow YAML file. The minimal recommended permissions block is permissions: {} (no permissions), but typically lint jobs only require access to contents: read. Add the following at the top workflow level (applies to all jobs unless overridden), just after the name: Lint key. The edit should be made to .github/workflows/lint.yml after line 15. No other changes or dependencies are needed.

Suggested changeset 1
.github/workflows/lint.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -13,6 +13,8 @@
 # limitations under the License.
 
 name: Lint
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -13,6 +13,8 @@
# limitations under the License.

name: Lint
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,4 +25,4 @@ jobs:
permissions:
pages: write
id-token: write
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@35aaff65a539af824d36a72aac42393a71092cc9
uses: 8hobbies/workflows/.github/workflows/npm-doc-pages.yml@0addb4a5f6d2598854f617fae0b907a0ecd34a1e
2 changes: 1 addition & 1 deletion .github/workflows/publish-dry-run.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
run:
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@35aaff65a539af824d36a72aac42393a71092cc9
uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@0addb4a5f6d2598854f617fae0b907a0ecd34a1e

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 2 months ago

To fix this problem, we should add a permissions block at the top level of the workflow or directly in the job. The safest default is to use permissions: read-all, which restricts the GITHUB_TOKEN to read-only across all permissions. If the called reusable workflow requires any write permissions, they should be set more granularly, but since this is a dry run publish, read-only is almost certainly sufficient. The recommended change is to add the following block after the workflow's name: declaration and before the on: trigger, for clarity and consistency:

permissions:
  contents: read

This explicitly scopes the permissions to be as minimal as possible for typical workflows, unless more is required by the called reusable workflow.

Suggested changeset 1
.github/workflows/publish-dry-run.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/publish-dry-run.yml b/.github/workflows/publish-dry-run.yml
--- a/.github/workflows/publish-dry-run.yml
+++ b/.github/workflows/publish-dry-run.yml
@@ -13,6 +13,8 @@
 # limitations under the License.
 
 name: Publish Dry Run
+permissions:
+  contents: read
 
 on:
   push:
EOF
@@ -13,6 +13,8 @@
# limitations under the License.

name: Publish Dry Run
permissions:
contents: read

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
tags: ["v*"]
jobs:
build:
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@35aaff65a539af824d36a72aac42393a71092cc9
uses: 8hobbies/workflows/.github/workflows/npm-publish.yml@0addb4a5f6d2598854f617fae0b907a0ecd34a1e
secrets:
npm-auth-token: ${{ secrets.NPM_TOKEN }}

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}
2 changes: 1 addition & 1 deletion .github/workflows/runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@

jobs:
test:
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@35aaff65a539af824d36a72aac42393a71092cc9
uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@0addb4a5f6d2598854f617fae0b907a0ecd34a1e

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {}

Copilot Autofix

AI about 2 months ago

To fix this problem, add a permissions block specifying least privilege at the top/root of the workflow file (globally for all jobs) or specifically under each job (here, there is only one job). Since this workflow delegates all work to the 8hobbies reusable workflow, we should use the most restrictive permissions unless more are required (in which case, delegated jobs will typically elevate as needed). The minimal, safest approach is to set permissions: {} (no access to the GITHUB_TOKEN) at the top/root level, which keeps the token as restricted as possible. Alternatively, if read access to repository contents is needed for the reusable workflow, set permissions: contents: read. Generally, permissions: {} is preferred for maximum security where no permissions are required at the delegator level.

Edit the .github/workflows/runtime.yml file by inserting a permissions: {} block after the name: line, ensuring all jobs have only the minimal permissions unless overridden. No new methods, imports, or definitions are needed.

Suggested changeset 1
.github/workflows/runtime.yml

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/.github/workflows/runtime.yml b/.github/workflows/runtime.yml
--- a/.github/workflows/runtime.yml
+++ b/.github/workflows/runtime.yml
@@ -13,6 +13,7 @@
 # limitations under the License.
 
 name: Runtime
+permissions: {}
 
 on:
   push:
EOF
@@ -13,6 +13,7 @@
# limitations under the License.

name: Runtime
permissions: {}

on:
push:
Copilot is powered by AI and may make mistakes. Always verify output.