-
Notifications
You must be signed in to change notification settings - Fork 0
Update 8hobbies/workflows digest to 44f8438 #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| jobs: | ||
| lint: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@4443153b7f57ef7295e48bb1f73e90cb8b28a0c4 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-lint.yml@44f843881a46dc28b2d66c154b1231649b43498a |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 18 days ago
To fix the problem, you should add a permissions block at the root of the workflow file (.github/workflows/lint.yml). This will ensure that any job in the workflow does not inherit excessive permissions from the repository, but instead uses only the minimum required. Since this workflow delegates to an external lint workflow via uses, we should use contents: read (typical for lint/test/check workflows), unless you know stricter permissions are possible. The permissions block should be inserted near the top, usually after the workflow name entry.
Steps:
- Edit
.github/workflows/lint.yml. - Insert the following after
name: Lint:This specifies that jobs by default only have read access to repository contents.permissions: contents: read
-
Copy modified lines R16-R17
| @@ -13,6 +13,8 @@ | ||
| # limitations under the License. | ||
|
|
||
| name: Lint | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
| jobs: | ||
| run: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@4443153b7f57ef7295e48bb1f73e90cb8b28a0c4 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-publish-dry-run.yml@44f843881a46dc28b2d66c154b1231649b43498a |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 18 days ago
To address the issue, explicitly add a permissions block to the workflow file. Since all jobs are contained within the single run job that uses a reusable workflow, and unless more specific permissions are needed, the minimal, safest configuration is contents: read. This ensures the GITHUB_TOKEN available to this workflow and any called workflows is limited to read-only permission for repository contents.
- The change should be inserted near the top-level of the workflow, i.e., after
name: Publish Dry Runand before theon:block, to apply to the entire workflow by default. - No new methods, variables, or imports are needed—just a YAML edit to add the
permissionsblock.
-
Copy modified lines R16-R17
| @@ -13,6 +13,8 @@ | ||
| # limitations under the License. | ||
|
|
||
| name: Publish Dry Run | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
| jobs: | ||
| test: | ||
| uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@4443153b7f57ef7295e48bb1f73e90cb8b28a0c4 | ||
| uses: 8hobbies/workflows/.github/workflows/npm-runtime.yml@44f843881a46dc28b2d66c154b1231649b43498a |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 18 days ago
How to fix:
Insert a permissions block at the top level of the workflow (just below name: and before on: is standard), to restrict default permissions for all jobs unless individually overridden. Unless the jobs (or the called reusable workflow) require specific write permissions, you should set the minimum, e.g., contents: read.
Detailed best fix:
Insert the following minimal block:
permissions:
contents: readThis ensures the GITHUB_TOKEN has only read access to repository contents for this workflow and all contained jobs (unless otherwise specified explicitly elsewhere). Place it directly under the name: Runtime entry in .github/workflows/runtime.yml.
What is needed:
No new methods, imports, or definitions; just an addition to the YAML workflow file.
-
Copy modified lines R16-R17
| @@ -13,6 +13,8 @@ | ||
| # limitations under the License. | ||
|
|
||
| name: Runtime | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: |
This PR contains the following updates:
4443153->44f8438Configuration
📅 Schedule: Branch creation - "on Sunday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.