merge the 'master' branch of openwrt #2
Merged
9849 merged 773 commits into9849:masterfrom Mar 28, 2018
Merged
Conversation
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Fixes issues with connections hanging after >30 seconds idle time Signed-off-by: Felix Fietkau <nbd@nbd.name>
…yet) It also does not have any users yet. It will be addde back when the core API issues have been sorted out Signed-off-by: Felix Fietkau <nbd@nbd.name>
…hooks Signed-off-by: Felix Fietkau <nbd@nbd.name>
Works around two incompatiblities between glibc and (POSIX-compliant) musl: - missing register definitions from asm/ptrace.h - non-POSIX-compliant ucontext_t on PPC32 with glibc Compile tested on mpc85xx. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
…bunwind Allow building perf on uncommon targets again. Depending on the kernel version, not all of these archs will actually use libunwind in perf. Still, it seems simpler and less error-prone to use the same list that is defined in the libunwind package. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
- fix TCP connection state - fix checksum error on DNAT Signed-off-by: Felix Fietkau <nbd@nbd.name>
When SFP support was accepted upstream, the expected GPIO names were slightly changed, breaking SFP insert detection. Update the DTS file to the expected name to make SFP work again. Fixes: 4ccad92 ("mvebu: Add support for kernel 4.14") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Add the patch for reprobing phys also for 4.14, as it is still needed. Fixes: 4ccad92 ("mvebu: Add support for kernel 4.14") Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
/lib/functions.sh can deal with Require-User specifications that only contain a group, but no user. Adjust metadata.pm to allow such specifications as well. Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
As each mvebu device only uses one of the firmwares provided by mwlwifi
package, it makes sense to put them in separate packages and only install
the one that is needed.
Current mwlwifi version's firmware sizes and usages by devices:
88W8864.bin 118776 caiman, mamba, cobra, shelby
88W8897.bin 489932 (none)
88W8964.bin 449420 rango
Changes by this commit:
* indicate in title that mwlwifi also is driver for 88W8897 and 88W8964
* remove mwlwifi package's firmware installation rules
* add 3 new individual firmware packages (all depends on kmod-mwlwifi):
- mwlwifi-firmware-88w8864
- mwlwifi-firmware-88w8897
- mwlwifi-firmware-88w8964
* add firmware package to mvebu devices' DEVICE_PACKAGES accordingly
Signed-off-by: Johnny S. Lee <_@jsl.io>
[Add the used FW files to the PACKAGES of default image]
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Vitalij Alshevsky <v_alshevsky@tut.by>
CPU: H3 Quad-core Cortex-A7 H.265/HEVC 4K @ 1.3 Ghz GPU: Mali400MP2 GPU @ 600MHz (supports OpenGL ES 2.0) Memory: 1GB DDR3 (shared with GPU) Onboard: Storage TF card (Max. 64GB) / MMC card slot Onboard: Network 10/100M Ethernet RJ45 Onboard header pinout: SPI, I2C, 1-WIRE USB 2.0: Three USB 2.0 HOST, One USB 2.0 OTG Buttons: Power Button(SW4) Debug TTL UART: ..DC-IN.. >[GND][RX][TX] ..HDMI.. Signed-off-by: Vitalij Alshevsky <v_alshevsky@tut.by>
With this, `mount -t efivarfs` is available and tools such as efitools and efibootmgr will be usable. Signed-off-by: Alif M. Ahmad <alive4ever@live.com> [daniel@makrotopia.org: some whitespace fixes, match From: with SoB]
When CGROUPS is enabled the new option CONFIG_CGROUP_NET_CLASSID is selectable and not handled. Add this option to the 4.14 kernel configuration. Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
This fixes a compile bug found by build bot with kernel 3.18 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
This bug was causing miscompiled code related to branch delay slots Signed-off-by: Felix Fietkau <nbd@nbd.name>
…nsfer Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
…es FS#1333) This reverts commit 968b861. Signed-off-by: Felix Fietkau <nbd@nbd.name>
Support config in the form of .... add_list sendopts=router:10.10.10.2 add_list sendopts=nissrv:20.20.20.2 add_list sendopts=0x7D:abba This allows to configure sendopts having white spaces as option value Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
Looking for a wrong LED file name was stopping this code from find any LED. This affects devices with only a red/amber power LED. Fixes: 3aaee1b ("bcm53xx: failsafe support") Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Upstream handling of MIPS CPU IRQs is rather hackish and the interrupts are being enabled unconditionally in various places because of legacy code. Performance counter events are routed both through the GIC and through legacy CPU IRQ7 events, causing spurious interrupts. Fix this by disabling IRQ7 when trying to access the performance counter IRQ. Signed-off-by: Felix Fietkau <nbd@nbd.name>
This will be required for Open vSwitch geneve tunneling support Signed-off-by: Yousong Zhou <yszhou4tech@gmail.com>
With this change, the timestamp variable is only used in ag71xx_check_dma_stuck. Small tx speedup. Based on a Qualcomm commit. ag->timestamp = jiffies was not replaced with netif_trans_update(dev) because of this quote: It should be noted that after this series several instances of netif_trans_update() are useless (if they occur in .ndo_start_xmit and driver doesn't set LLTX flag -- stack already did an update). From: http://lists.openwall.net/netdev/2016/05/03/87 Signed-off-by: Rosen Penev <rosenp@gmail.com>
Remove RPS/XPS support from netifd core, move the logic to a hotplug script that uses a different policy which provides better performance and more fairness across flows Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
The GPIO configuration in the DTS have as third parameter the active low/high configuration. This parameter is not easy to parse by humans when it is only set to 0/1. It is better to use the predefined constants GPIO_ACTIVE_HIGH and GPIO_ACTIVE_LOW. Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
The AVM Fritz!Box 4040 uses an IPQ4018 as SoC and not an IPQ4019. The DTS must be adjusted to reflect this. Signed-off-by: Sven Eckelmann <sven@narfation.org>
There is currently no code to read the phy reset gpios for the ethernet PHY. It would also have been better to use the more common name "phy-reset-gpios" for this property. Signed-off-by: Sven Eckelmann <sven@narfation.org>
The APPSBL and anything after that it not allowed to touch some of the memory regions which are used by other components. Still trying to write to the memory can lead to sudden device restarts (IPQ40xx) # mw 87e80000 0 data abort pc : [<873149f8>] lr : [<87308578>] sp : 86edfc28 ip : 86ef4412 fp : 00000000 r10: 00000000 r9 : 00000000 r8 : 86edff68 r7 : 0000000 r6 : 8737e624 r5 : 86ef4420 r4 : 8736c154 r3 : 00000000 r2 : 00000010 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs off FIQs off Mode SVC_32 Resetting CPU ... The device manufacturer only provided a very rough list of regions: * rsvd1: 0x87000000 0x500000 * wifi_dump: 0x87500000 0x600000 * rsvd2: 0x87b00000 0x500000 A more detailed list for devices using the AP.DK reference design memory maps was provided by Roman Yeryomin <roman@advem.lv> in commit 56f2df879fd ("ipq806x: ipq4019: add ap-dk01.1-c1 board support"): * apps_bl: 0x87000000 0x400000 * sbl: 0x87400000 0x100000 * cnss_debug: 0x87500000 0x600000 * cpu_context_dump: 0x87b00000 0x080000 * tz_apps: 0x87b80000 0x280000 * smem: 0x87e00000 0x080000 * tz: 0x87e80000 0x180000 The u-boot function ipq_fdt_mem_rsvd_fixup seems to suggest that only the rsvd2 (tz_apps, smem, tz) should be protected. All other regions would have been removed by it when CONFIG_QCA_APPSBL_DLOAD is not enabled. This allows to reduce the 16MB reserved memory region to only 4.5MB. Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
The APPSBL and anything after that it not allowed to touch some of the memory regions which are used by other components. Still trying to write to the memory can lead to sudden device restarts (IPQ40xx) # mw 87e80000 0 data abort pc : [<873149f8>] lr : [<87308578>] sp : 86edfc28 ip : 86ef4412 fp : 00000000 r10: 00000000 r9 : 00000000 r8 : 86edff68 r7 : 0000000 r6 : 8737e624 r5 : 86ef4420 r4 : 8736c154 r3 : 00000000 r2 : 00000010 r1 : 00000000 r0 : 00000000 Flags: nZCv IRQs off FIQs off Mode SVC_32 Resetting CPU ... The device manufacturer only provided a very rough list of regions: * rsvd1: 0x87000000 0x500000 * wifi_dump: 0x87500000 0x600000 * rsvd2: 0x87b00000 0x500000 A more detailed list for devices using the AP.DK reference design memory maps was provided by Roman Yeryomin <roman@advem.lv> in commit 56f2df879fd ("ipq806x: ipq4019: add ap-dk01.1-c1 board support"): * apps_bl: 0x87000000 0x400000 * sbl: 0x87400000 0x100000 * cnss_debug: 0x87500000 0x600000 * cpu_context_dump: 0x87b00000 0x080000 * tz_apps: 0x87b80000 0x280000 * smem: 0x87e00000 0x080000 * tz: 0x87e80000 0x180000 The u-boot function ipq_fdt_mem_rsvd_fixup seems to suggest that only the rsvd2 (tz_apps, smem, tz) should be protected. All other regions would have been removed by it when CONFIG_QCA_APPSBL_DLOAD is not enabled. This allows to reduce the 16MB reserved memory region to only 4.5MB. Signed-off-by: Sven Eckelmann <sven.eckelmann@openmesh.com>
WHR-G300N has 5 ethernet ports (lan: 4, wan: 1), but there was no correct configuration in 02_network script and 6 ports was configured on the switch. Also, since the MAC address was not acquired from factory partition, incorrect values was set to LAN and WAN interfaces. This commit fixes these issues. Signed-off-by: INAGAKI Hiroshi <musashino.open@gmail.com>
During upstreaming the intel phy driver, support for the vr9 v1.1 embedded phys got lost. Backport the upstream send patch adding support for the vr9 v1.1 embbeded phys to the driver. Signed-off-by: Mathias Kresin <dev@kresin.me> cosmetic fixes Signed-off-by: Mathias Kresin <dev@kresin.me>
…stablished Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
3aad294 libubox: Plug a small memory leak. eebe3fc utils: use constant byte-order conversion Signed-off-by: Felix Fietkau <nbd@nbd.name>
Update DEPENDS and PROVIDES so that ath10k-ct firmware and drivers can be used to replace stock firmware and drivers. The -htt firmware variant, which requires ath10k-ct driver now selects ath10k-ct driver when the firmware is selected. Signed-off-by: Ben Greear <greearb@candelatech.com>
Among other things, this will check for an htt-mgt variant of ath10k-ct firmware before loading 'normal' firmware, and it disables verbose printing of firmware DBGLOG messages by default. Signed-off-by: Ben Greear <greearb@candelatech.com>
This updates to latest ath10k-ct firmware. Hopefully we are
at the end of the development cycle for this firmware release,
so these should be stable.
wave-1 changes since last release:
Release 20
* Allow flushing peer when deleting. Hopefully this will allow the
peer delete command to happen in a reasonable amount of time even
if the RF environment is busy (or peer has died).
To enable this, set the high flag in the mac-addr second word in the
ath10k driver near end of the ath10k_wmi_op_gen_peer_delete method:
cmd->peer_macaddr.word1 |= __cpu_to_le32(0x80000000);
* Attempt to fix crash seen in resmgr-ocs, appearantly due to list corruption.
Use a temporary list instead of trying to rely on for-each-safe.
* Add flag to tx-descriptor to allow driver to request no-ack on data
frames. This is bit 15 on the flag1 field (previously un-used).
* Add option to support specifying the tx-rate-code and retry count on
a per-packet basis. Only a single series is supported at this time.
Useful mainly for radiotap monitor-tx type testing at this point.
* Fix crash on startup when chip is at -40 deg C and calibration fails. Instead
of asserting, just keep retrying calibration, which appears to start working
after a few minutes (when the chip warms up).
* Allow reporting per-chain rssi for management frames. We pack the values into
empty space in the mgt-frame wmi header. This will only be enabled if the driver
requests it, since otherwise the driver is assumed to not understand the new API.
ath10k-ct drivers that support this feature will automatically enable it.
* A customer reports a case that appears to be the hardware not properly detecting
end of AMPDU, so frames were being mis-delivered to the wrong peer. Attempt to
work around this, and in doing so, clean up a bunch of void* abuse in the block-ack
reordering code (could not ever confirm there was a problem in this area).
* Re-work the rx-mem logic to be less complicated and to use less memory.
* Attempt to fix crash that appearanty happens because the driver can sometimes
delete a vdev in 'up' state.
* Attempt to fix hung scan state machine issues.
* Fix crash in tx path due to un-initialized memory.
wave-2 changes since last release:
Release 10
* Fix an assert related to tx scheduling. This hopefully fixes
what appears to be a regression that I added some time back.
* Enable CSI reporting for 9984, and maybe 9888/9886. Only in
non-trimmed builds.
* Other stability improvements, including regression fixes from
some tricky bugs introduced in earlier releases.
* Allow compiling for IPQ4019 chipset.
* Firmware will now send txbf frames to the host (driver) if the
TXBF (0xF00000001) set-special feature is enabled, or when the radio
is in monitor mode. But, if the frame is consumed by the txbf_cv
logic, then the pkt cannot be delivered to the host in this manner. Instead,
a WMI event will be sent and host can find the txbf_cv data in shared
memory. See ath10k_wmi_event_txbf_cv_mesg() in ath10k-ct driver.
* Support rx-all-mgt option. When enabled, the firmware will deliver all
management frames that it can to the host. No RX filters are changed
when this option is enabled.
* Fix at least some problems with sending tx-beamforming frames to SU-MIMO
peers. Looks like this was a regression in my code.
* Fix a crash in rate-ctrl due to nss mismatch. This was something I introduced
while trying to fix other bugs in rate-ctrl some time back.
* Attempt to fix a sw-peer-key object leak in IBSS mode. The peer key code
is very complex, and shares some pointers as union members. I think I fixed
at least some of the issues, but would not be surprised if more exist.
* Improve ath10k user guide to document CT firmware features:
https://www.candelatech.com/ath10k-ug.php
* Add ct-special option to configure the txbf sounding time. See ath10k-ug.php
* Fix and allow the driver to tell the firmware to send sounding frames. See ath10k-ug.php
In further testing, this seems to fail much of the time, and I am not sure why.
Disabling this in diet (trimmed) builds.
* Fix crashes related to deleting peers while they are in power-save mode. Reported
by LEDE user on r7800 with 9984 NIC.
* Make rate-ctrl txbf probe work better. If enabled, the rate-ctrl logic will periodically
send out probes at an NSS that can to txbf. Previously, txbf probes would not reliably happen
if both AP and peer had the same nss (ie, 2x2 talking to 2x2). To enable this feature, you
need to enable the fwtest-cmdid number 20.
* Report rx-timeout error counters. These were previously un-reported, though the
field existed in the wmi struct already.
* txbf: Ignore frames not destined for us. If NIC is in promisc mode, it
could acquire and process NDPA frames that were not destined for it. Check
the dest-MAC and ignore frames not for us (pass them up the stack for monitor
mode instead of save them in the peer's rate-ctrl logic.)
* Port ping-pong crash handling and othe related features to IPQ4019 target. It should
now act similar to 9984 in this regard.
* Fix a few asserts related to txbf and tx-seq logic.
* Add custom-stats support, for rx-reorder-stats. Similar to what I did for wave-1.
* Disable AMSDU for IBSS. This now matches what I did for peregrine. It seems to
work better this way, though I did not debug it in detail.
* Enable the set-special command to re-enable AMSDU for IBSS if user wants to experiment.
* Fix bug where dbglog did not disable IRQs, so if you made dbglog messages from the IRQ
handler, it could cause corruption that could crash the firmware and/or corrupt the log
message buffers.
* Don't assert if there are no buffer descriptors for RX of non-data frame.
* Retry any stuck block-ack sessions every 20 seconds instead of just disabling BA for
ever when we get too many failures.
* Fix SGI flag when reporting tx-rate info. The flag moved since wave-1 days, and
I did not notice that when I ported my changes forward to wave-2.
* Allow disabling special CCA handling for IBSS txqs. Earlier testing indicated this
might improve throughput in some testing on 9984 chips in IBSS mode, but subsequent
testing looks about the same without it. Since I do not really understand what this
setting exists for, leave it at upstream defaults. A new set-special API command (0x12)
can be used to enable this hack for testing. Setting 0x1 bit disables special CCA handling
for non-beacon IBSS txqs, setting 0x2 bit disables it for beacon queues as well.
* Add MCAST-BCAST feature flag. This tells driver we do not need a monitor interface
to do MESH.
* When calculating the rx-address filter (affects ACK & BLOCK-ACK, among other things),
to not add in monitor interfaces if other interfaces are up. There is no need for
a monitor device to ACK frames.
Signed-off-by: Ben Greear <greearb@candelatech.com>
The HTT-MGT variants transport management frames over the normal HTT tx path, just like data frames. This saves limitted WMI buffers which can become depleted if lots of management frames become stuck in TX queues due to peer that went away. In addition, at least for the wave-1 firmware, htt-mgt is required in order for 802.11r (fast roaming) authentication to function properly. The htt-mgt firmware requires the use of the ath10k-ct driver. Normal non-htt-mgt ath10k-ct firmware should work with stock drivers. Signed-off-by: Ben Greear <greearb@candelatech.com>
PKG_EXTMOD_SUBDIRS should be set to the sub directory where the kernel module gets build in, for the ath10k-ct driver this changed in commit 3888e77 from ath10k to ath10k-4.13. Without this fix the depends line of the ath10*.ko modules is empty and the kernel module load system will not automatically load the depended modules like mac80211. Fixes: 3888e77 ("ath10k-ct driver: use dma_alloc_coherent, 4.13 based driver") Fixes: 23a388f ("ath10k-ct: Force loading mac80211 and ath modules.") Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
Relevant changes: 0afc1be Fixes for kernel 4.16 d2d6780 Reinitialise overhead compensation stats when reconfiguring. a3bab9d Export overhead compensation stats to userspace. 9cd2fa8 Split tin stats to its own structure to decrease size of tc_cake_xstats 71c7b44 Gather more statistics about packet length transformations. 0517357 Rework overhead compensation to use dynamic transport header offset instead of (inaccurate) static one. c1a0c8e Refactor length handling code to better centralise overhead calculations Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Cake in kernel space now splits stats structure handling across netlink messages to reduce stack usage issue flagged by upstream kernel checks. Update user space (tc) qdisc handling to understand this new regime. Cake also reports packet overheads & compensation in a different way so add display code for this. e.g. 'tc -s qdisc show dev eth0' reports this extra detail: min/max transport layer size: 28 / 1500 min/max overhead-adjusted size: 65 / 1550 average transport hdr offset: 14 Cake also supports output in JSON format. Patch is bulkier than before because a (slightly out of date - see above stats) man page is included for reference. Better than nothing! Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Right patch version this time, sorry! * Patch 180-usb-xhci-add-support-for-performing-fake-doorbell.patch had to be adjusted slightly because of upstream adapted code. * Refreshed patches. Compile-tested: ramips/mt7621, x86/64 Run-tested: ramips/mt7621, x86/64 Signed-off-by: Stijn Segers <foss@volatilesystems.org> Tested-by: Rosen Penev <rosenp@gmail.com>
Contains kernel 4.14 updates. Compile tested on mvebu. Signed-off-by: Rosen Penev <rosenp@gmail.com>
This will generate image for Pine64 Sopine board. Signed-off-by: Fan Fan <fkpwolf@gmail.com>
Improve portability of init script by declaring resolvfile as local in dnsmasq_stop function. Fixes resolvfile being set for older busybox versions in dnsmasq_start in a multi dnsmasq instance config when doing restart; this happens when the last instance has a resolvfile configured while the first instance being started has noresolv set to 1. Base on a patch by "Phil" Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
This audio chip is provided as a virtual audio device by VMware Signed-off-by: Felix Fietkau <nbd@nbd.name>
Netfilter flow offload has now started to become useful and suitable for a wider testing audience. Configuring it via UCI is also integrated in firewall3 by adding 'option flow_offloading 1' to the 'defaults' section in /etc/config/firewall Signed-off-by: Felix Fietkau <nbd@nbd.name>
9c8d781 netifd: return the interface for locally addressable host dependencies Signed-off-by: Felix Fietkau <nbd@nbd.name>
5d2bf09 uci: fix a potential use-after-free in uci_set() 3b3d63e list: only record ordering deltas if element position changed 4c4d343 cmake: Fix cli shared linking against ubox Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
The following patches were merged upstream: 000-hostapd-Avoid-key-reinstallation-in-FT-handshake.patch replaced by commit 0e3bd7ac6 001-Prevent-reinstallation-of-an-already-in-use-group-ke.patch replaced by commit cb5132bb3 002-Extend-protection-of-GTK-IGTK-reinstallation-of-WNM-.patch replaced by commit 87e2db16b 003-Prevent-installation-of-an-all-zero-TK.patch replaced by commit 53bb18cc8 004-Fix-PTK-rekeying-to-generate-a-new-ANonce.patch replaced by commit 0adc9b28b 005-TDLS-Reject-TPK-TK-reconfiguration.patch replaced by commit ff89af96e 006-WNM-Ignore-WNM-Sleep-Mode-Response-without-pending-r.patch replaced by commit adae51f8b 007-FT-Do-not-allow-multiple-Reassociation-Response-fram.patch replaced by commit 2a9c5217b 008-WPA-Extra-defense-against-PTK-reinstalls-in-4-way-ha.patch replaced by commit a00e946c1 009-Clear-PMK-length-and-check-for-this-when-deriving-PT.patch replaced by commit b488a1294 010-Optional-AP-side-workaround-for-key-reinstallation-a.patch replaced by commit 6f234c1e2 011-Additional-consistentcy-checks-for-PTK-component-len.patch replaced by commit a6ea66530 012-Clear-BSSID-information-in-supplicant-state-machine-.patch replaced by commit c0fe5f125 013-WNM-Ignore-WNM-Sleep-Mode-Request-in-wnm_sleep_mode-.patch replaced by commit 114f2830d Some patches had to be modified to work with changed upstream source: 380-disable_ctrl_iface_mib.patch (adding more ifdef'ery) plus some minor knits needed for other patches to apply which are not worth being explicitely listed here. For SAE key management in mesh mode, use the newly introduce sae_password parameter instead of the psk parameter to also support SAE keys which would fail the checks applied on the psk field (ie. length and such). This fixes compatibility issues for users migrating from authsae. Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution to OpenWrt!
To help keep the codebase consistent and readable,
and to help people review your contribution,
we ask you to follow the rules you find in the wiki at this link
https://lede-project.org/submitting-patches
Please remove this message before posting the pull request.