gerrit_project: allow slashes in repo path of gerrit remote#74
Merged
9999years merged 1 commit into9999years:mainfrom Feb 9, 2026
Merged
gerrit_project: allow slashes in repo path of gerrit remote#749999years merged 1 commit into9999years:mainfrom
9999years merged 1 commit into9999years:mainfrom
Conversation
Otherwise, remote URLs such as `ssh://ma27@cl.afnix.fr:2022/rokc/rokc` are rejected by this tool.
9999years
approved these changes
Feb 9, 2026
Owner
9999years
left a comment
9999years
left a comment
There was a problem hiding this comment.
sweet tysm, honestly this regex is still super aggressive and maybe should just be like .+ or something? but it's been a while since i've looked at the code. now we get to find out if my release automation works!
Owner
|
yeah the release automation is cooked. i'll fix it eventually |
Contributor
|
Nice, I have some similar small tweaks in a stack lying around as well that I hope to get around to submitting. |
Owner
|
@Ma27 Got the release automation fixed, your change is published here! https://github.com/9999years/git-gr/releases/tag/v1.4.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, remote URLs such as
ssh://ma27@cl.afnix.fr:2022/rokc/rokcare rejected by this tool.cc @9999years