Skip to content

Scrum 146 be 캐릭터 도감 api 연동#34

Merged
GideokKim merged 5 commits intodevfrom
SCRUM-146-BE-캐릭터-도감-API-연동
Apr 16, 2025

Hidden character warning

The head ref may contain hidden characters: "SCRUM-146-BE-\uce90\ub9ad\ud130-\ub3c4\uac10-API-\uc5f0\ub3d9"
Merged

Scrum 146 be 캐릭터 도감 api 연동#34
GideokKim merged 5 commits intodevfrom
SCRUM-146-BE-캐릭터-도감-API-연동

Conversation

@Ryan-OH
Copy link
Copy Markdown
Collaborator

@Ryan-OH Ryan-OH commented Apr 16, 2025

Explain this Pull Request 🙏

What has fixed? 🛠

변경 전 내용

변경 후 내용
캐릭터 도감 연동 API + 프론트엔드 추가요청이 있어서 파일수정했습니다

Whether needed review 🖍

  • 🙋🏻 리뷰가 필요합니다!
  • 🙅🏻 리뷰가 필요하지 않습니다!

(이유 : )

Document🗒️ (Optional)

Screenshot 📸 (Optional)

Test Checklist ✅ (Optional)

@Ryan-OH Ryan-OH self-assigned this Apr 16, 2025
@GideokKim GideokKim force-pushed the SCRUM-146-BE-캐릭터-도감-API-연동 branch 2 times, most recently from ccebc7a to eabf747 Compare April 16, 2025 02:01
@GideokKim GideokKim added the enhancement New feature or request label Apr 16, 2025
Comment thread app/api/v1/router.py
Comment thread app/crud/character.py
Comment thread app/crud/user_character.py
@GideokKim GideokKim force-pushed the SCRUM-146-BE-캐릭터-도감-API-연동 branch from eabf747 to f9d6e29 Compare April 16, 2025 02:15
@trivialcoding6
Copy link
Copy Markdown
Collaborator

LGTM

Copy link
Copy Markdown
Member

@GideokKim GideokKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM API 개발하시느라 고생하셨습니다!

@GideokKim GideokKim force-pushed the SCRUM-146-BE-캐릭터-도감-API-연동 branch from c1d1d00 to 0e8a9f3 Compare April 16, 2025 05:38
@GideokKim GideokKim merged commit 83c4d19 into dev Apr 16, 2025
@GideokKim GideokKim deleted the SCRUM-146-BE-캐릭터-도감-API-연동 branch April 16, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants