Add mobile duplicate push payload guards

[9thLevelSoftware]

Summary

• Deduplicate repeated WorkoutSession.id values before building portal push payloads and before post-push timestamp stamping.
• Add a local duplicate-key preflight for workout_sessions, exercises, sets, rep_summaries, and rep_telemetry that fails fast with PortalApiException instead of sending a doomed request.
• Add regression coverage for exact duplicate session rows, nested duplicate exercise IDs, and stable adapter ID mapping.

Testing

• :shared:testAndroidHostTest --tests com.devil.phoenixproject.data.sync.SyncManagerTest
• :shared:testAndroidHostTest --tests com.devil.phoenixproject.data.sync.PortalPushLimitsTest
• :shared:validateSchemaManifest :shared:testAndroidHostTest

[gemini-code-assist]

Code Review

This pull request introduces local deduplication and preflight validation for push payloads in SyncManager to prevent duplicate key errors during portal synchronization. It adds dedupeWorkoutSessionsById to filter out duplicate workout sessions and rejectDuplicatePushPayloadKeys to fail the sync early if duplicate nested keys are detected. Feedback recommends making the workout session deduplication case-insensitive to align with the preflight validation, extending duplicate checks to routines and cycles, and updating unit tests to verify case-insensitive deduplication.

[Copilot]

Pull request overview

Adds defensive guards to prevent duplicate IDs from producing invalid portal sync push payloads, and ensures repeated WorkoutSession.id rows don’t cause duplicate exercise IDs or duplicate post-push stamping.

Changes:

• Deduplicate WorkoutSession rows by id before building portal push payloads and before post-push timestamp stamping.
• Add a local preflight that detects (case-insensitive) duplicate IDs across push payload tables (workout_sessions, exercises, sets, rep_summaries, rep_telemetry) and fails fast with PortalApiException.
• Add regression tests covering duplicate session IDs, nested duplicate exercise IDs, and stable exercise ID derivation.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
shared/src/commonMain/kotlin/com/devil/phoenixproject/data/sync/SyncManager.kt	Adds session deduping and push-payload duplicate-key preflight before network push.
shared/src/commonTest/kotlin/com/devil/phoenixproject/testutil/FakeSyncRepository.kt	Tracks post-push stamping calls to assert deduped stamping behavior in tests.
shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/SyncManagerTest.kt	Adds sync regression tests for deduping and local duplicate-key rejection.
shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/PortalSyncAdapterTest.kt	Adds test ensuring exercise IDs remain stable (derived from workout session ID).
shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/PortalPushLimitsTest.kt	Adds test for case-insensitive duplicate detection across all push payload tables.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 357d57c3b1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Stamp dropped duplicate session aliases

When the duplicate differs only by case (the new test even uses id and id.uppercase()), this dedupes the post-push list before calling updateSessionTimestamp, so only the kept casing is marked synced. The SQL update is an exact WHERE id = ?, while the delta query keeps returning rows with updatedAt IS NULL; therefore the dropped alias is selected on the next sync and can be pushed as a standalone payload, defeating the duplicate guard and potentially overwriting the portal row you meant to suppress.

Useful? React with 👍 / 👎.

[kilo-code-bot]

Code Review Roast 🔥

Verdict: No New Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything.

The duplicate detection logic is solid, the tests are comprehensive, and the code follows existing patterns. The existing comment about locale-sensitive lowercase() (line 1539) is valid but already flagged.

📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are.

Files Reviewed (4 files)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/data/sync/SyncManager.kt - 3 new functions for duplicate handling
• shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/SyncManagerTest.kt - 2 new tests
• shared/src/commonTest/kotlin/com/devil/phoenixproject/data/sync/PortalPushLimitsTest.kt - 1 new test
• shared/src/commonTest/kotlin/com/devil/phoenixproject/testutil/FakeSyncRepository.kt - 1 new field

---

_{Reviewed by laguna-m.1-20260312:free · 1,451,782 tokens}