Skip to content

Add TV remote navigation for sliders and editable fields#510

Merged
9thLevelSoftware merged 3 commits into
mainfrom
feat/437-tv-remote-navigation
Jun 7, 2026
Merged

Add TV remote navigation for sliders and editable fields#510
9thLevelSoftware merged 3 commits into
mainfrom
feat/437-tv-remote-navigation

Conversation

@9thLevelSoftware

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings June 7, 2026 15:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@9thLevelSoftware 9thLevelSoftware linked an issue Jun 7, 2026 that may be closed by this pull request
2 tasks

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces TV remote (D-pad) input support across various UI components by implementing platform-specific input mode detection, a custom ConfirmEditTextField to handle editing states, and an ExpressiveSlider with D-pad navigation support. Feedback on these changes highlights several usability improvements: ensuring D-pad Up/Down events are only consumed when focus successfully moves to avoid breaking page scrolling, resetting the editing state in ConfirmEditTextField upon keyboard action completion, and specifying explicit steps for integer-based ExpressiveSlider instances to prevent sluggish or unresponsive behavior.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58573f42c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- DpadSliderSemantics: return only `moved` for focus-move commands so
  failed moves bubble to parent scroll/focus handlers instead of being
  consumed unconditionally
- ConfirmEditTextField: wrap keyboard actions to reset isEditing state
  on Done/Go/Search/Send/Next/Previous, preventing double-back-press
  requirement after soft keyboard commit
- ExerciseConfigModal & ProgressionSettingsSheet: add explicit
  remoteStep = 1f for crisp single-unit D-pad increments on integer
  percentage sliders
- Resolve merge conflict in SettingsTab.kt (accept new imports from main)

https://claude.ai/code/session_01BGjenvs8VmxnBv1WZAbDo4
@9thLevelSoftware 9thLevelSoftware merged commit 27e48ef into main Jun 7, 2026
9 checks passed
@9thLevelSoftware 9thLevelSoftware deleted the feat/437-tv-remote-navigation branch June 7, 2026 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Navigation via TV Remote

3 participants