Add TV remote navigation for sliders and editable fields#510
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces TV remote (D-pad) input support across various UI components by implementing platform-specific input mode detection, a custom ConfirmEditTextField to handle editing states, and an ExpressiveSlider with D-pad navigation support. Feedback on these changes highlights several usability improvements: ensuring D-pad Up/Down events are only consumed when focus successfully moves to avoid breaking page scrolling, resetting the editing state in ConfirmEditTextField upon keyboard action completion, and specifying explicit steps for integer-based ExpressiveSlider instances to prevent sluggish or unresponsive behavior.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58573f42c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- DpadSliderSemantics: return only `moved` for focus-move commands so failed moves bubble to parent scroll/focus handlers instead of being consumed unconditionally - ConfirmEditTextField: wrap keyboard actions to reset isEditing state on Done/Go/Search/Send/Next/Previous, preventing double-back-press requirement after soft keyboard commit - ExerciseConfigModal & ProgressionSettingsSheet: add explicit remoteStep = 1f for crisp single-unit D-pad increments on integer percentage sliders - Resolve merge conflict in SettingsTab.kt (accept new imports from main) https://claude.ai/code/session_01BGjenvs8VmxnBv1WZAbDo4
No description provided.