Refactor UI elements and improve password handling logic#630
Merged
fho4abcd merged 8 commits intoABCD-DEVCOM:masterfrom Apr 5, 2026
Merged
Refactor UI elements and improve password handling logic#630fho4abcd merged 8 commits intoABCD-DEVCOM:masterfrom
fho4abcd merged 8 commits intoABCD-DEVCOM:masterfrom
Conversation
… selector below the distributorLogo
Update www/htdocs/central/dataentry/change_password.php JavaScript: remove deprecated language attribute from the <script> tag, consolidate PHP-built alert text into $msg_alerta and escape it with addslashes to prevent JS syntax errors from quotes in translations, declare confirm_password with var and add missing semicolons, and apply minor whitespace/formatting cleanup.
Normalize indentation, line breaks, and stray control characters in www/htdocs/central/dataentry/js/password_check.js. This commit only adjusts formatting for readability and maintainability; there are no functional changes to the password validation logic.
Add a guard in ReservesAssign so it returns an 8-element array of empty strings when no reservations are assigned, preventing 'Undefined variable' errors in calling code. Also update the CHANGE LOG entry formatting and add a comment explaining the new non-NULL return behavior; remove an extraneous separator line and make minor formatting adjustments. Corrects old errors: [05-Apr-2026 04:26:10 Europe/Berlin] PHP Warning: Trying to access array offset on value of type null in C:\xampp\htdocs\ABCD2\www\htdocs\central\circulation\devolver_ex.php on line 284 [05-Apr-2026 04:26:10 Europe/Berlin] PHP Warning: Trying to access array offset on value of type null in C:\xampp\htdocs\ABCD2\www\htdocs\central\circulation\devolver_ex.php on line 283
Normalize/fix character encoding in Portuguese language files to correct garbled accented characters. Updates applied to pt dbadmin.tab files for Linux/Windows and central language file, plus settings/admin_logs.php so UI strings render correctly and accented characters display as intended.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.