Open
Conversation
claude used to discover itertools.accumulate for prefix sum calculations and implement Stack.unjoin
implemented only for dataarray and dataset inputs, despite merge accepting dicts too. The implementation should preserve attributes.
claude used to reduce redundant test code. also moved input checking to class init instead of in join method
covers Concatenate InterpLike GeospatialTimeSeriesMerge
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the join numpy/dask/xarray operations. It also implements the corresponding unjoin methods for some of the simpler join methods. doc strings were also updated to reflect what can/can't be undone. the doc strings should now describe whether a notimplementederror or noop happens if an unjoin is not implemented.
Will create an issue listing which unjoins haven't been implemented.
Getting Started
Docstrings
Did not create new classes/functions. Left existing doc strings as they are and only updated doc strings related to undo functionality.
Test Coverage
Documentation
not needing documentation update
Final Checks:
Alternatively, if generative AI was used, then confirm you have:
Claude Opus and Sonnet 4.6 used to write numpy unjoin methods and clean up my hand-written test code. Also used for general queries e.g. (what does x do).
Finally,