Conversation
edoyango
approved these changes
Apr 24, 2026
Collaborator
edoyango
left a comment
edoyango
left a comment
There was a problem hiding this comment.
using the .copy() method is probably fine imo since the methods are expecting DataArray, Dataset, ndarry; and it's a shallow copy (which what type(x)(x) was doing anyway).
Collaborator
Author
|
Great. If a simple .copy seems reasonable, I'll tidy this up and get it merged. Thanks for the quick feedback! |
… create a copy of a dataset
…ather than leveraging pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not convinced that this fix is universal, or only works on datasets. I am guessing the original code is trying to make a copy, but in a more polymorphic way rather than assume the class of the object. However, maybe using the python copy.copy library would be suitable, or maybe a type-aware if statement to use an xarray-specific approach for data sets and fall back to the current code otherwise. But the tests pass, which is good.
AI Usage Summary: nil AI was used