Modified the way data is accessed from pivoted_plot_data to avoid problems with NaN in some lines#110
Closed
MarinManuel wants to merge 1 commit intoACCLAB:masterfrom
MarinManuel:fix-paired-colors
Closed
Modified the way data is accessed from pivoted_plot_data to avoid problems with NaN in some lines#110MarinManuel wants to merge 1 commit intoACCLAB:masterfrom MarinManuel:fix-paired-colors
pivoted_plot_data to avoid problems with NaN in some lines#110MarinManuel wants to merge 1 commit intoACCLAB:masterfrom
MarinManuel:fix-paired-colors
Conversation
…roblems with NaN in some lines
Jacobluke-
added a commit
that referenced
this pull request
Apr 17, 2023
- Fixed bug preventing non-string columns to be used - Modified the way data is accessed from pivoted_plot_data to avoid problems with NaN in some lines (from PR #110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposed fix for #103
The issue seems that the
pivoted_plot_datatable contains columns for allidxpairs, but someid(rows) could only have data in some of the idx pairs and not others.I have changed the way this data is accessed when looping through the
idxpairs, and drop NaN rows to get rid of unnecessary rows.It seems pytest passed all the tests, so hopefully this change does not break anything. Maybe this dataset (or a synthetic equivalent) could be added to the test suite?