Add E0 re-estimation and LoRA improvements#1297
Merged
ilyes319 merged 26 commits intoACEsuit:developfrom Feb 10, 2026
Merged
Conversation
add finetuning for mh-1 and omol
fix concurrency tests
Contributor
|
hey @ttompa thx for that! could you move the lora_tools.py to the modules folder. The philosophy is that heavy pytorch codes that changes things in the model belongs to the modules folder and the tools are more python or less model architecture code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add LoRA weight merging and improved E0 estimation for fine-tuning
This PR introduces two main improvements for model fine-tuning:
LoRA weight merging: After training with LoRA adapters, the learned weights are now automatically merged back into the base model weights before saving. This produces a standard model file without unnecessary overhead.
Enhanced E0 estimation: Added a new
--E0s="estimated"option for fine-tuning foundation models. Instead of simple averaging, this estimates atomic reference energies by:This approach provides a better estimate for the E0s compared to the existing
"average"method when isolated energies are not available.Additional changes include LoRA delta caching in eval mode for faster training and additional unit tests.