Adding a MACE-MDP foundation model calculator and supporting cueq=True for AtomicDielectricMACE#1439
Open
Nilsgoe wants to merge 11 commits intoACEsuit:developfrom
Open
Adding a MACE-MDP foundation model calculator and supporting cueq=True for AtomicDielectricMACE#1439Nilsgoe wants to merge 11 commits intoACEsuit:developfrom
Nilsgoe wants to merge 11 commits intoACEsuit:developfrom
Conversation
Mace mu alpha
Cueq support for AtomicDielectricMACE
transpose_mul_ir converts CuEq linear output ir_mul→mul_ir before the block, so hardcode layout="mul_ir" instead of get_layout(). Fixes cueq=True/False inconsistency for models with non-scalar MLP_irreps. Update cueq matrix test to use MLP_irreps with 1o+2e components and add rotation equivariance checks for dipole and polarizability.
…ut blocks GatedEquivariantBlock natively supports both "mul_ir" and "ir_mul" layouts, so the transpose sandwich (ir_mul→mul_ir before gate, mul_ir→ir_mul after) is unnecessary. Use get_layout(cueq_config) directly instead.
Adding the final version of MACE-MDP as a foundation model calculator and AtomicDielectricMACE with cueq=True working
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces [MACE-MDP](https://github.com/Nilsgoe/MACE-MDP) as a possible calculator for directly computing dipole moments and polarizabilities in organic systems (molecules and condensed phases).
Additionally, it supports
cueq=Truethanks to the newGatedEquivariantBlockadded in the development branch; to ensure correctness, I have included an additional test.