New release #39
Merged
New release #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com>
* Create reservations overview page * Fix comment Change variable name
* Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests
* Add exclude history to get product reservation method * Clean in-memory database after every reservation test * Rewrite reservation tests to remove hardcoded date values * Add tests for get product reservation method * Remove time from the product reservation method query * Fix date tests for reservation * Fix dates in "enddate before current date error" test * Move excludeHistory to query parameter * retrigger checks Co-authored-by: SieBrum <siebrenkraak@hotmail.com>
* Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * gateway route en renterid fix * Enum creation * ENUM usage, fixed error message * retrigger checks * not implemented exception for delete reservation Co-authored-by: SieBrum <siebrenkraak@hotmail.com>
SieBRUM
added a commit
that referenced
this pull request
Jun 8, 2021
* Rename ItemService to ProductService (#31) * Fix ProductService release (#39) * 107 catalogus inzien (#33) * Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> * Create reservations overview page (#42) * Create reservations overview page * Fix comment Change variable name * Fix SonarCloud environment (#36) * Product tests (#32) * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests * Remove ItemTests because it's obselete Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com>
|
[backend-product-service] Kudos, SonarCloud Quality Gate passed!
|
|
[backend-reservation-service] Kudos, SonarCloud Quality Gate passed!
|
MKet
approved these changes
Jun 8, 2021
SieBRUM
added a commit
that referenced
this pull request
Jun 8, 2021
* Rename ItemService to ProductService (#31) * Fix ProductService release (#39) * 107 catalogus inzien (#33) * Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> * Create reservations overview page (#42) * Create reservations overview page * Fix comment Change variable name * Fix SonarCloud environment (#36) * Product tests (#32) * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests * Remove ItemTests because it's obselete * 112 winkelwagen tests (#33) * Add exclude history to get product reservation method * Clean in-memory database after every reservation test * Rewrite reservation tests to remove hardcoded date values * Add tests for get product reservation method * Remove time from the product reservation method query * Fix date tests for reservation * Fix dates in "enddate before current date error" test * Move excludeHistory to query parameter * retrigger checks Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * 25 leen status aanpassen (#34) * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * gateway route en renterid fix * Enum creation * ENUM usage, fixed error message * retrigger checks * not implemented exception for delete reservation Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * FIx routes (#40) Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com>
Noodleyy
pushed a commit
that referenced
this pull request
Feb 22, 2022
* Rename ItemService to ProductService (#31) * Fix ProductService release (#39) * 107 catalogus inzien (#33) * Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> * Create reservations overview page (#42) * Create reservations overview page * Fix comment Change variable name * Fix SonarCloud environment (#36) * Product tests (#32) * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests * Remove ItemTests because it's obselete * 112 winkelwagen tests (#33) * Add exclude history to get product reservation method * Clean in-memory database after every reservation test * Rewrite reservation tests to remove hardcoded date values * Add tests for get product reservation method * Remove time from the product reservation method query * Fix date tests for reservation * Fix dates in "enddate before current date error" test * Move excludeHistory to query parameter * retrigger checks Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * 25 leen status aanpassen (#34) * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * gateway route en renterid fix * Enum creation * ENUM usage, fixed error message * retrigger checks * not implemented exception for delete reservation Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * FIx routes (#40) * Entityframework Tools added * Open all browsers added * Images error fixed * Added Migrations * Updated Entity Framework * Fixed reservation call * Add userspage compatibility * Add OverviewUser.cs OverviewUser has been added so that no unnecessary data will be sent * Add Tests for Usercontroller * searchbar werkt eindelijk * Add ban and unban functionality * UnitTests Added * Change Users to include UserInfo * Edit Userdata for database * doing the filter on the back end * de testen werken nu ook * Edit OverviewUser.cs To be compatible with the front-end * Searchfilter + tests added to catalog * should work * Update ocelot.Development.json * Search functie is klaar en allemaal getest Ik moet nog misschien een test maken dat de category filter en search bar tegelijkertijd gebruikt * Fix merge error UserController * Inventory krijgt nu ook category * Add paginator punctionality to overview page * Fix capitalization in GetSimilarReservations * PDF service made * Endpoints added to ocelot * endpoints added * WERKT * login token * Update AccountController.cs small improvements, checks for login * Fix Login Namespace issues * Add tests to login * push * PDF tests added * Add perma-block function * Fixed pagesize filter * Fix Ocelot.Development.json * Fix GetInventoryItems returning wrong items * Converter klaar Co-authored-by: Siebren Kraak <siebrenkraak@hotmail.com> Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com> Co-authored-by: Bart Pelsma <Bart.pelsma@hotmail.com> Co-authored-by: Cyrion <cyrion.vandongen@student.fontys.nl> Co-authored-by: Michael Bednarek <446633@student.fontys.nl> Co-authored-by: DaanBrouwer <daanbrouwer96@gmail.com>
Noodleyy
added a commit
that referenced
this pull request
Feb 22, 2022
* Dev (#41) * Rename ItemService to ProductService (#31) * Fix ProductService release (#39) * 107 catalogus inzien (#33) * Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> * Create reservations overview page (#42) * Create reservations overview page * Fix comment Change variable name * Fix SonarCloud environment (#36) * Product tests (#32) * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests * Remove ItemTests because it's obselete * 112 winkelwagen tests (#33) * Add exclude history to get product reservation method * Clean in-memory database after every reservation test * Rewrite reservation tests to remove hardcoded date values * Add tests for get product reservation method * Remove time from the product reservation method query * Fix date tests for reservation * Fix dates in "enddate before current date error" test * Move excludeHistory to query parameter * retrigger checks Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * 25 leen status aanpassen (#34) * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * gateway route en renterid fix * Enum creation * ENUM usage, fixed error message * retrigger checks * not implemented exception for delete reservation Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * FIx routes (#40) Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com> * Update README.md * Dev (#48) * Rename ItemService to ProductService (#31) * Fix ProductService release (#39) * 107 catalogus inzien (#33) * Added catalog functions * Catalog test * Added some comments * Image tests * PR changes * last PR change * pr change without test fixes * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Fix tests and change contexts * Added catalog functions * Added some comments * Catalog test * PR changes * Image tests * last PR change * pr change without test fixes * Catalog test * PR changes * Fix tests and change contexts * Add config to contructor in catalogtests Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: SieBrum <siebrenkraak@hotmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> * Create reservations overview page (#42) * Create reservations overview page * Fix comment Change variable name * Fix SonarCloud environment (#36) * Product tests (#32) * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Rename ItemTests to ProductTests * Fix ShouldReturnLastPage test * Remove GetProduct method * Fix comment in InventoryPage * Update Product tests * Remove generic getproducts method * Add sanity checks to inventory item method * Seperate shared state from Product tests to fix race conditions * Add tests for add product * Fix ShouldReturnLastPage test * Remove GetProduct method * Clean up type casting in Product tests * Remove ItemTests because it's obselete * 112 winkelwagen tests (#33) * Add exclude history to get product reservation method * Clean in-memory database after every reservation test * Rewrite reservation tests to remove hardcoded date values * Add tests for get product reservation method * Remove time from the product reservation method query * Fix date tests for reservation * Fix dates in "enddate before current date error" test * Move excludeHistory to query parameter * retrigger checks Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * 25 leen status aanpassen (#34) * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * Added action model, Http call and added PickedUpDate in Reservation * Similar reservations call * Removed check enddate on similar reservations * gateway route en renterid fix * Enum creation * ENUM usage, fixed error message * retrigger checks * not implemented exception for delete reservation Co-authored-by: SieBrum <siebrenkraak@hotmail.com> * FIx routes (#40) * Entityframework Tools added * Open all browsers added * Images error fixed * Added Migrations * Updated Entity Framework * Fixed reservation call * Add userspage compatibility * Add OverviewUser.cs OverviewUser has been added so that no unnecessary data will be sent * Add Tests for Usercontroller * searchbar werkt eindelijk * Add ban and unban functionality * UnitTests Added * Change Users to include UserInfo * Edit Userdata for database * doing the filter on the back end * de testen werken nu ook * Edit OverviewUser.cs To be compatible with the front-end * Searchfilter + tests added to catalog * should work * Update ocelot.Development.json * Search functie is klaar en allemaal getest Ik moet nog misschien een test maken dat de category filter en search bar tegelijkertijd gebruikt * Fix merge error UserController * Inventory krijgt nu ook category * Add paginator punctionality to overview page * Fix capitalization in GetSimilarReservations * PDF service made * Endpoints added to ocelot * endpoints added * WERKT * login token * Update AccountController.cs small improvements, checks for login * Fix Login Namespace issues * Add tests to login * push * PDF tests added * Add perma-block function * Fixed pagesize filter * Fix Ocelot.Development.json * Fix GetInventoryItems returning wrong items * Converter klaar Co-authored-by: Siebren Kraak <siebrenkraak@hotmail.com> Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com> Co-authored-by: Bart Pelsma <Bart.pelsma@hotmail.com> Co-authored-by: Cyrion <cyrion.vandongen@student.fontys.nl> Co-authored-by: Michael Bednarek <446633@student.fontys.nl> Co-authored-by: DaanBrouwer <daanbrouwer96@gmail.com> Co-authored-by: Siebren Kraak <siebrenkraak@hotmail.com> Co-authored-by: jobverwiel <47630915+jobverwiel@users.noreply.github.com> Co-authored-by: Angelo Bruggemans <I412999@fhict.nl> Co-authored-by: Myron Antonissen <myron.antonissen@gmail.com> Co-authored-by: Marco Ketelaars <marco-ketelaars94@hotmail.com> Co-authored-by: MKet <MKet@users.noreply.github.com> Co-authored-by: XanderPruimen <92432835+XanderPruimen@users.noreply.github.com> Co-authored-by: Bart Pelsma <Bart.pelsma@hotmail.com> Co-authored-by: Cyrion <cyrion.vandongen@student.fontys.nl> Co-authored-by: Michael Bednarek <446633@student.fontys.nl> Co-authored-by: DaanBrouwer <daanbrouwer96@gmail.com> Co-authored-by: Jonah Broers <jonah@rebelit.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.