Skip to content

Salt facility#64

Merged
Fingel merged 177 commits intoAEONplus:mainfrom
saltastroops:salt-facility
May 7, 2026
Merged

Salt facility#64
Fingel merged 177 commits intoAEONplus:mainfrom
saltastroops:salt-facility

Conversation

@hettlage
Copy link
Copy Markdown
Contributor

@hettlage hettlage commented May 7, 2026

This PR integrates the Southern African Large Telescope (SALT).

@hettlage
Add initial file layout for SALT models
d5e027d
@hettlage
Add the observation request model
9f47c17
@hettlage
Merge branch 'main' into salt-facility
b3980a7
@hettlage
Add a first version of the block model
5773030
@hettlage
Add a first version of the SALT sidereal target model
905fa7f
@hettlage
Add the magnitude range model
8b07329
@hettlage
Add Pydantic validators for checking greater than or equal to and les…
be49a16 
…s than or equal to relations
@hettlage
Add the constraints model
0dc058b
@hettlage
Replace the Ge and Le validators with GreaterEqual and LessEqual
8860589
@hettlage
Handle the case of zero maximum visits correctly
b72c1e7
@hettlage
Use an AstroPy Angle instead of an AstroPy Quantity
c42efbc
@hettlage
Fix the GreaterEqual and LessEqual validator
17b4a3f
@hettlage
Allow only right ascension values supported by SALT
91fe20a
@hettlage
Move model tests into separate files
0639e01
@hettlage
Move literal types into separate files
588a1e5
@hettlage
Update the Block model to use the Constraints model
5ed2ef3
@hettlage
Fix minor language issues
57a3abe
@hettlage
Add validators for greater than and less than relations
d0e66bc
@hettlage
Add the acquisitions model
dedf481
@hettlage
Merge branch 'main' into salt-facility
0601fb7
@hettlage
Fix a formatting issue
598b6d4
@hettlage
Add a type annotation for defining custom types based on an AstroPy Q…
057482e 
…uantity
@hettlage
Add types for a duration
59cf06e
@hettlage
Type the exposure time as a positive duration
7602f37
@hettlage
Refactor the validation for the target right ascension
50446c5 
The rationale is that the same validation should be applied to a reference star and hence its code should be as reusable as possible.
@hettlage
Fix the target coordinate validation
4a2c044
@hettlage
Add the reference star model
d4922f5
@hettlage
Add the acquisition model in the block model
1af9fd7
@hettlage
Add an Instrument type
5f83ed7
@hettlage
Refactor the model import
6566ec1
@hettlage
Add a method for mapping attachments to paths for the submitted XML
5a28564
@hettlage
Fix the name of the dummy slit mask file
25a2df9
@hettlage
Add zip file export
d105a6b
@hettlage
Serialize observation windows
07b212f
@hettlage
Fix linting issues
3f686ef
@hettlage
Add a section on SALT to the README
79ee33b
@hettlage
Add PyAstroSALT as a dependency
086f23f
@hettlage
Add SALT configuration settings
8a01149
@hettlage
Handle missing windows
bd390a4
@hettlage
Fix name of the file containing the submitted blocks
470119e
@hettlage
Remove wrong type from Hrs documentation
47cc917
@hettlage
Handle the case of no arc request correctly
b39f7e7
@hettlage
Move conftest.py
d12e1ee
@hettlage
Remove extraneous whitespace in XML
229914e
@hettlage
Fix the type hint for blocks
699882e
@hettlage
Upgrade PyAstroSALT
3b08519
@hettlage
Revert dependency issues because of Pydantic issue
0d51eaf 
It seems that pydantic_settings 2.14 did not pick up environment variable values.
@hettlage
Update PyAstroSALT dependency
25ceffc
@hettlage
Add the SALT facility class
3b3859b
@hettlage
Add an example notebook for SALT observation requests
c8943b4
@hettlage
Merge branch 'main' into salt-facility
2826d00 
# Conflicts:
#	uv.lock
@hettlage
Update the uv lock file
9602f40 
There seem to be issues with reading in values from a .env file when you upgrade pydantic-settings.
@hettlage
Fix a formatting issue
349bd21
@hettlage
Include SALT dependencies when testing
272ce59
@Fingel
Copy link
Copy Markdown
Contributor

Fingel commented May 7, 2026

It works!

[SubmissionMessageType.INFO] Calling the submission script.
[SubmissionMessageType.INFO] Starting submission.
[SubmissionMessageType.INFO] Checking proposal feasibility.
[SubmissionMessageType.INFO] Generating finding charts for block Sombrero Galaxy 2
[SubmissionMessageType.INFO] Inserting the proposal into the database.
[SubmissionMessageType.INFO] Inserting block Sombrero Galaxy 2
[SubmissionMessageType.INFO] The submission finished successfully
The submission was successful. The proposal code is 2026-1-DDT-001.

Fingel
Fingel requested changes May 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Fingel Fingel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really great. Just one comment on the "tt.txt" file. Are you OK with closing #58 in favor of this PR? If the types end up being useful outside of SALT, we can extract them.

Comment thread src/tt.txt Outdated
@Fingel Fingel merged commit a994f3a into AEONplus:main May 7, 2026
3 checks passed
@Fingel Fingel mentioned this pull request May 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fingel Fingel Fingel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hettlage @Fingel