Skip to content

Increase backup subsidy total share#3396

Merged
jason-aelf merged 1 commit intomasterfrom
hotfix/increase-backup-subsidy-totalshare
Apr 18, 2023
Merged

Increase backup subsidy total share#3396
jason-aelf merged 1 commit intomasterfrom
hotfix/increase-backup-subsidy-totalshare

Conversation

@jason-aelf
Copy link
Copy Markdown
Collaborator

Add a new function called IncreaseBackupSubsidyTotalShare to the smart contract ProfitContract.

Add a new function called `IncreaseBackupSubsidyTotalShare` to the smart contract `ProfitContract`.
@vizipi
Copy link
Copy Markdown

vizipi Bot commented Apr 18, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
100.00 % EanCuznaivy 174 4
100.00 % xiangxingxing 27 4
100.00 % weili 24 4
100.00 % gldeng 9 4
100.00 % Peng Rong 7 4
100.00 % 轩辕焮痕 1 4

Potential missing files from this Pull request

files commonly committed with a subset of this pr, but not committed this time. (click to collapse)
FilePercentilerate
protobuf/election_contract.proto80.00 %12 out of 15 times
test/AElf.Contracts.Election.Tests/BVT/ElectionTests.cs80.00 %12 out of 15 times
...contract/AElf.Contracts.Election/ElectionContract_Elector73.33 %11 out of 15 times
test/AElf.Contracts.Profit.Tests/ProfitContractTestBase.cs73.33 %11 out of 15 times
...test/AElf.Contracts.Election.Tests/Full/ReleaseProfitsFro73.33 %11 out of 15 times
...test/AElf.Contracts.Economic.TestBase/ContractsPreparatio73.33 %11 out of 15 times
contract/AElf.Contracts.Treasury/TreasuryContract.cs66.67 %10 out of 15 times
contract/AElf.Contracts.MultiToken/TokenContract_Actions.cs66.67 %10 out of 15 times
protobuf/token_contract.proto66.67 %10 out of 15 times
contract/AElf.Contracts.Profit/ViewMethods.cs60.00 %9 out of 15 times

Committed file ranks

(click to expand)
  • 98.43%[protobuf/profit_contract.proto]
  • 98.61%[test/AElf.Contracts.Profit.Tests/ProfitTests.cs]
  • 93.47%[contract/AElf.Contracts.Profit/ProfitContractState.cs]
  • 99.69%[contract/AElf.Contracts.Profit/ProfitContract.cs]
  • @vizipi vizipi Bot requested review from gldeng, hzz780 and rosona April 18, 2023 04:19
    @codecov
    Copy link
    Copy Markdown

    codecov Bot commented Apr 18, 2023

    Codecov Report

    Merging #3396 (6be5cd9) into master (b4df4f6) will increase coverage by 0.00%.
    The diff coverage is 100.00%.

    Additional details and impacted files

    Impacted file tree graph

    @@           Coverage Diff           @@
    ##           master    #3396   +/-   ##
    =======================================
      Coverage   90.91%   90.92%           
    =======================================
      Files         640      640           
      Lines       24007    24015    +8     
      Branches     2104     2104           
    =======================================
    + Hits        21827    21835    +8     
      Misses       2075     2075           
      Partials      105      105           
    Impacted Files Coverage Δ
    contract/AElf.Contracts.Profit/ProfitContract.cs 93.67% <100.00%> (+0.07%) ⬆️

    @jason-aelf jason-aelf merged commit a0804d7 into master Apr 18, 2023
    @delete-merged-branch delete-merged-branch Bot deleted the hotfix/increase-backup-subsidy-totalshare branch April 18, 2023 05:56
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    5 participants