Skip to content

feat: hw-app-aelf#1

Open
yongenaelf wants to merge 5 commits into
developfrom
feat/hw-app-aelf
Open

feat: hw-app-aelf#1
yongenaelf wants to merge 5 commits into
developfrom
feat/hw-app-aelf

Conversation

@yongenaelf
Copy link
Copy Markdown

📝 Description

JS Bindings for AElf

❓ Context

  • Impacted projects: ``
  • Linked resource(s): ``

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@vizipi
Copy link
Copy Markdown

vizipi Bot commented Sep 11, 2023

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code.
This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
10.00 % Valentin D. Pinkman 90 1
10.00 % Julien Elbaz 37 1
10.00 % @greweb 34 1
10.00 % Gregor Gilchrist 21 1
10.00 % Hakim 18 1
10.00 % nparigi-ledger 13 1

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

(click to expand)
  • 77.44%[libs/ledgerjs/packages/hw-app-elf/tests/Elf.unit.test.ts]
  • 50.64%[libs/ledgerjs/packages/hw-app-elf/src/Elf.ts]
  • 50.64%[libs/ledgerjs/packages/hw-app-elf/README.md]
  • 99.99%[pnpm-lock.yaml]
  • 9.92%[libs/ledgerjs/packages/hw-app-elf/package.json]
  • 0.00%[libs/ledgerjs/packages/hw-app-elf/jest.config.ts]
  • 0.00%[libs/ledgerjs/packages/hw-app-elf/tsconfig.json]
  • 0.00%[libs/ledgerjs/packages/hw-app-elf/CHANGELOG.md]
  • 0.00%[libs/ledgerjs/packages/hw-app-elf/tests/tsconfig.json]
  • 0.00%[libs/ledgerjs/packages/hw-app-elf/src/utils.ts]
  • Comment thread libs/ledgerjs/packages/hw-app-elf/src/Elf.ts Outdated
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants