fix: renamed preprocessor conditionals for SLOW_LIGHT#111
Merged
gnwong merged 1 commit intoAFD-Illinois:masterfrom Apr 30, 2026
Merged
fix: renamed preprocessor conditionals for SLOW_LIGHT#111gnwong merged 1 commit intoAFD-Illinois:masterfrom
gnwong merged 1 commit intoAFD-Illinois:masterfrom
Conversation
pedronaethe
changed the title
Collaborator
|
Wow, this is quite concerning. I think this actually does not affect (most of?) the slow light runs that we generated for other projects (looking at my version of the slow light code), but it should definitely be fixed here. It's also not completely clear to me which runs are affected (I'm sure some of the runs I'd generated are), so perhaps the safest advisement is to redo anything that someone can't trace the progeny of. That said, I know we typically use high cadence GRMHD snapshots and test convergence in snapshot sampling rate, so hopefully the effects of this aren't too severe... |
Collaborator
|
@c-prather @avjoshi21 @vedantdhruv96 @cfgammie I'm accepting this and merging it now but figured I should tag you all just in case you didn't see. |
gnwong
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a major bug in slowlight where the function
interp_scalar_timewas executed wrongly due to incorrect preprocessor conditional directives.As a result, plasma variables were not interpolated across dump files. Instead, the code returned values from the earliest loaded dump between the two that should be interpolated, leading to incorrect results without triggering any warnings or runtime errors.
The issue has been corrected by fixing the conditional compilation directive controlling slowlight. I have verified that it compiles successfully, but haven't tested runtime behavior.