Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

[Issue 85] by default, use http basic auth to include client credentials in requests#87

Closed
samskiter wants to merge 2 commits intoAFNetworking:masterfrom
samskiter:use-http-basic-auth
Closed

[Issue 85] by default, use http basic auth to include client credentials in requests#87
samskiter wants to merge 2 commits intoAFNetworking:masterfrom
samskiter:use-http-basic-auth

Conversation

@samskiter
Copy link
Copy Markdown

Pretty self explanatory. as per #85 , we should no be putting client credentials in the request body. This is a rough port of a similar PR for AFOAuth2Client v1

@samskiter
Copy link
Copy Markdown
Author

TODO: we could use NSURLCredential to do this.

mattt added a commit that referenced this pull request Mar 2, 2015
…conditionally encode client credentials in Base64-encoded HTTP Authorization header field, rather than in body of request.
@mattt
Copy link
Copy Markdown
Contributor

mattt commented Mar 2, 2015

Thanks for your PR, @samskiter. I ended up implementing this functionality in a slightly different way with 412d256. Please look for this in the forthcoming release.

@mattt mattt closed this Mar 2, 2015
@samskiter
Copy link
Copy Markdown
Author

Brilliant, thank for your work on this @mattt

I should probably point out that the comment you added doesn't match with the way you implemented:

Initializes an `AFOAuth2Manager` object with the specified base URL, client identifier, and secret. The communication to to the server will use HTTP basic auth by default (use `-(id)initWithBaseURL:clientID:secret:withBasicAuth:` to change this).

should read:

Initializes an `AFOAuth2Manager` object with the specified base URL, client identifier, and secret. The communication to to the server will use HTTP basic auth by default (change the `useHTTPBasicAuthentication` property to change this).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants