This repository was archived by the owner on Jan 17, 2023. It is now read-only.
[Issue 85] by default, use http basic auth to include client credentials in requests#87
Closed
samskiter wants to merge 2 commits intoAFNetworking:masterfrom
Closed
[Issue 85] by default, use http basic auth to include client credentials in requests#87samskiter wants to merge 2 commits intoAFNetworking:masterfrom
samskiter wants to merge 2 commits intoAFNetworking:masterfrom
Conversation
Author
|
TODO: we could use NSURLCredential to do this. |
mattt
added a commit
that referenced
this pull request
Mar 2, 2015
Contributor
|
Thanks for your PR, @samskiter. I ended up implementing this functionality in a slightly different way with 412d256. Please look for this in the forthcoming release. |
Author
|
Brilliant, thank for your work on this @mattt I should probably point out that the comment you added doesn't match with the way you implemented: should read: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty self explanatory. as per #85 , we should no be putting client credentials in the request body. This is a rough port of a similar PR for AFOAuth2Client v1