Skip to content
This repository was archived by the owner on Mar 11, 2023. It is now read-only.

Simplify by dropping cache_args.#105

Merged
Seluj78 merged 2 commits intoAFPy:masterfrom
JulienPalard:mdk/cache-args
Dec 27, 2020
Merged

Simplify by dropping cache_args.#105
Seluj78 merged 2 commits intoAFPy:masterfrom
JulienPalard:mdk/cache-args

Conversation

@JulienPalard
Copy link
Copy Markdown
Collaborator

@JulienPalard JulienPalard commented Dec 3, 2020

Though there were not enough pull request on this repo :p

@Seluj78
Copy link
Copy Markdown
Collaborator

Seluj78 commented Dec 3, 2020

The thing is, if we remove cache args, then some fonctionnality will break because excluded items are in the cache

@JulienPalard
Copy link
Copy Markdown
Collaborator Author

I don't see how it's possible, can you please provide a minimal reproductible example of what would break?

@Seluj78
Copy link
Copy Markdown
Collaborator

Seluj78 commented Dec 27, 2020

So, the idea is, when you use the cache, the arguments passed in the exclude are also not included in the cache, so if you run potodo --exclude c-api/ then run potodo the c-api still won't be here. I need to test this, gimme a sec

@Seluj78
Copy link
Copy Markdown
Collaborator

Seluj78 commented Dec 27, 2020

Ok well I got lost in my git config but it seems it work !

@Seluj78 Seluj78 merged commit eed6d80 into AFPy:master Dec 27, 2020
@JulienPalard JulienPalard deleted the mdk/cache-args branch December 31, 2020 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants