Normalize runner status handling and ensure timeout cleanup in execution API#17
Open
fractional-pm wants to merge 1 commit intomainfrom
Open
Normalize runner status handling and ensure timeout cleanup in execution API#17fractional-pm wants to merge 1 commit intomainfrom
fractional-pm wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
clearTimeoutis always called.RUNNING) separately from success and error.Description
normalizeRunnerStatusto map various runner status strings (e.g.COMPLETED,DONE,FAILED) to a canonicalSUCCESS/ERROR/RUNNINGset.statusvariable to includeRUNNINGand preserve the initial execution record asRUNNINGwhen created.fetchcall in atry/finallyso the timeout is always cleared, and setstatusbased on the normalized runner response payload.ERRORon exceptions and only setcompletedAtwhenstatus === 'SUCCESS'.Testing
pnpm testand all tests completed successfully.pnpm buildto validate typings and the build and it succeeded.Codex Task