[Performance] Not set request uuid to resolve performance regression#228
Merged
vipannalla merged 1 commit intomainfrom Mar 19, 2025
Merged
[Performance] Not set request uuid to resolve performance regression#228vipannalla merged 1 commit intomainfrom
vipannalla merged 1 commit intomainfrom
Conversation
Collaborator
|
thank you so much @wyzhang for helping fix this! |
liurupeng
approved these changes
Mar 19, 2025
Why: When set request uuid, it can trigger jax.jit recompilation for maxtext due to request uuid being unique, resulting in performance regression.
wyzhang
force-pushed
the
wyzhang/perf/regression
branch
from
50f0a60 to
92ba8bc
Compare
vipannalla
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
When set request uuid, it can trigger jax.jit recompilation for maxtext due to request uuid being unique, resulting in performance regression.