Skip to content

Remove Jetstream UT check from Add Label#236

Closed
jyj0w0 wants to merge 3 commits intomainfrom
yijiaj/add_yaml
Closed

Remove Jetstream UT check from Add Label#236
jyj0w0 wants to merge 3 commits intomainfrom
yijiaj/add_yaml

Conversation

@jyj0w0
Copy link
Copy Markdown
Collaborator

@jyj0w0 jyj0w0 commented Apr 7, 2025

Remove Jetstream UT check from Add Label

@jyj0w0 jyj0w0 requested a review from vipannalla as a code owner April 7, 2025 18:55
@vipannalla
Copy link
Copy Markdown
Collaborator

Why do you want to bypass the unitest check?

@jyj0w0
Copy link
Copy Markdown
Collaborator Author

jyj0w0 commented Apr 9, 2025

Why do you want to bypass the unitest check?

Probably a temp bypass since I noticed some PRs are checked in without unit tests passed, but we still want to add the tag if the PR could checked in.

@vipannalla
Copy link
Copy Markdown
Collaborator

Do you know which modules are not passing the coverage check? A better option is to reduce the coverage limit temporarily to 90% instead of disabling it.

@vipannalla
Copy link
Copy Markdown
Collaborator

I've update the test coverage to 90% in #237.

@jyj0w0
Copy link
Copy Markdown
Collaborator Author

jyj0w0 commented Apr 10, 2025

I've update the test coverage to 90% in #237.

Thanks! I would close this PR then.

@jyj0w0 jyj0w0 closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants