V5e8 ray #159
Merged
V5e8 ray #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wang2yn84
approved these changes
Jul 30, 2024
| ) | ||
| num_hosts = num_hosts if num_hosts > 0 else tpu.get_current_pod_worker_count() | ||
| print(f"pod_name:{pod_name}, number of host: {num_hosts}") | ||
| assert ( |
There was a problem hiding this comment.
Nit, consider adding more assertion to check the number of hosts * working chips == total devices.
lsy323
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add ray support for v5e-8 vms.
Thanks Richard for adding 8 chips TPU support in ray. But there is an issue to get get_current_pod_worker_count for v5e-8, this RP add parameter to let engineer specify worker count.