-
Notifications
You must be signed in to change notification settings - Fork 8
Support running inference with KV cache on Kithara's MaxText models. #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lienchen0526
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some python readability stuff here. We can discuss which can be a good practice from both of our sides
Collaborator
Author
|
thank you Jerry for the thorough code review! And thanks for catching the typo :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates MaxEngine with Kithara's MaxTextModel to improve inference performance. Previously, model inference (i.e.
MaxTextModel.generate()) is supported via a naive autoregressive for-loop without KV Cache, which results in slow tokens per second for longer sequences. Now, inference for MaxTextModel is backed by a KV Cache system.Fast inference is required for supporting online and offline evaluation, as well as on-policy RLHF.
It should also be mentioned that Kithara's
KerasHubModel.generate()is already backed by KV Cache.Key Changes
max_prefill_predict_lengthparameter. This parameter determines the max prefill length.Testing