Skip to content

Patch llama3.1 model support #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2025
Merged

Patch llama3.1 model support #5

merged 1 commit into from
Mar 10, 2025

Conversation

@wenxindongwork
Copy link
Collaborator

@wenxindongwork wenxindongwork commented Mar 7, 2025

  1. Llama3 tokenizers don't have a default pad_token id. This PR sets it to fall back to other special tokens
  2. Added Llama3 FSDP to PredefinedShardingStrategy
  3. Refactored llama3 loading and saving tests into same test suites as the gemma models
  4. Fixed some bugs on model weights similarity metric calculation

TODO:

  • MaxText Llama3.1 model saving is failing.

@wenxindongwork wenxindongwork merged commit 5957e12 into main Mar 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandrasekhard2 chandrasekhard2 chandrasekhard2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wenxindongwork @chandrasekhard2