Support uploading models to HuggingFace Hub #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
wenxindongwork
commented
Mar 11, 2025
wenxindongwork
commented
- Added support for uploading models directly to HuggingFace Hub. This means the user now has three options for saving a model: to local directory, to GCS, or to HuggingFace Hub.
- Added unit tests
- Updated docs.
richardsliu
reviewed
Mar 12, 2025
docs/source/lora.rst
Outdated
|
|
||
| model.save_in_hf_format( | ||
| local_dir_or_gs_bucket, | ||
| local_dir_or_gs_bucket_or_hf_hub, |
yixinshi
reviewed
Mar 12, 2025
| print(f"\n Created new HuggingFace Hub {repo_type} repo: {repo_id}.") | ||
|
|
||
|
|
||
| def copy_local_file_to_huggingface_hub(local_path, file_name, repo_id, repo_type): |
Collaborator
There was a problem hiding this comment.
Better use "upload" than "copy" to be consistent to the term both the hf API uses and the GCS interface uses.
Collaborator
Author
|
Thank you for the code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.