Merged
Conversation
Collaborator
entrpn
commented
Jul 9, 2025
entrpn
commented
- Adds context parallelism to flash attention fn.
- Adds better sharding constraints when reshaping and padding to reduce AGs.
coolkp
reviewed
Jul 14, 2025
| if multi_slice_env: | ||
| dcn_parallelism = fill_unspecified_mesh_axes(dcn_parallelism, num_slices, "DCN") | ||
| mesh = mesh_utils.create_hybrid_device_mesh(ici_parallelism, dcn_parallelism, devices) | ||
| mesh = mesh_utils.create_hybrid_device_mesh(ici_parallelism, dcn_parallelism, devices, allow_split_physical_axes=config.allow_split_physical_axes) |
Collaborator
There was a problem hiding this comment.
I also discovered that cloud tpus, don't have "slice_index" attribute which is used in create_hybrid_mesh and also couple lines up to determine dcn or not, maybe we should pass process_is_granule=True to create_hybrid_device_mesh
coolkp
reviewed
Jul 14, 2025
coolkp
reviewed
Jul 14, 2025
Collaborator
|
Awesome PR ! excited for the perf gains! |
coolkp
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.