Conversation
…er/maxdiffusion into conversion-script
entrpn
reviewed
Jul 24, 2025
| if not enable_single_replica_ckpt_restoring: | ||
| item = {checkpoint_item: orbax.checkpoint.args.PyTreeRestore(item=abstract_unboxed_pre_state)} | ||
| return checkpoint_manager.restore(latest_step, args=orbax.checkpoint.args.Composite(**item)) | ||
| if checkpoint_item == " ": |
Collaborator
There was a problem hiding this comment.
should this be if checkpoint_item is None?
Contributor
Author
There was a problem hiding this comment.
if checkpoint set to None, cannot pass the check "if checkpoint_manager and checkpoint_item:" in max_utils.py. So I set it to empty string to get around this
| pipeline = LTXVideoPipeline.from_pretrained(config, enhance_prompt=enhance_prompt) | ||
| if config.pipeline_type == "multi-scale": | ||
| pipeline = LTXMultiScalePipeline(pipeline) | ||
| # s0 = time.perf_counter() |
Collaborator
There was a problem hiding this comment.
remove commented out lines.
Contributor
Author
There was a problem hiding this comment.
Do we want to keep the time benchmarking in the code?
| ) | ||
| if state: | ||
| state = state[checkpoint_item] | ||
| if checkpoint_item == " ": |
Collaborator
There was a problem hiding this comment.
why is checkpoint_item checking against " " instead of None?
| skip_block_list=config.first_pass["skip_block_list"], | ||
| ) | ||
| latents = result | ||
| print("first pass done") |
Collaborator
There was a problem hiding this comment.
use max_logger for print statements
Collaborator
when I run these instructions, I get an error: Traceback (most recent call last):
File "/mnt/disks/external_disk/maxdiffusion/src/maxdiffusion/generate_ltx_video.py", line 20, in <module>
from maxdiffusion.pipelines.ltx_video.ltx_video_pipeline import LTXVideoPipeline
File "/mnt/disks/external_disk/maxdiffusion/src/maxdiffusion/pipelines/ltx_video/ltx_video_pipeline.py", line 20, in <module>
from maxdiffusion.models.ltx_video.autoencoders.vae_torchax import TorchaxCausalVideoAutoencoder
File "/mnt/disks/external_disk/maxdiffusion/src/maxdiffusion/models/ltx_video/autoencoders/vae_torchax.py", line 17, in <module>
from maxdiffusion.models.ltx_video.autoencoders.causal_video_autoencoder import CausalVideoAutoencoder
File "/mnt/disks/external_disk/maxdiffusion/src/maxdiffusion/models/ltx_video/autoencoders/causal_video_autoencoder.py", line 28, in <module>
from diffusers.utils import logging
ModuleNotFoundError: No module named 'diffusers' |
Collaborator
|
Do you need to update requirements.txt for new dependencies? |
Contributor
Author
Will need to install diffusers. Is this okay? I can add this in the requirements.txt |
Collaborator
Yes just update the requirements accordingly. |
…puter/maxdiffusion into vae-pipeline-cleaned
entrpn
approved these changes
Jul 28, 2025
mailvijayasingh
approved these changes
Jul 28, 2025
Perseus14
added a commit
that referenced
this pull request
Apr 11, 2026
An empty file with a single-space filename (' ') was accidentally
committed in PR #208. This is an invalid path on Windows/NTFS,
causing git checkout, git stash, and other operations to fail with:
error: invalid path ' '
This removes the empty file to fix Windows compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running Instructions:
Create a new virtual environment with conda create, and run bash setup.sh MODE=stable DEVICE=tpu
python convert_torch_weights_to_jax.py --ckpt_path [LOCAL DIRECTORY FOR WEIGHTS] --transformer_config_path ../xora_v1.2-13B-balanced-128.json
python src/maxdiffusion/generate_ltx_video.py src/maxdiffusion/configs/ltx_video.yml output_dir="[SAME DIRECTORY]" config_path="src/maxdiffusion/models/ltx_video/xora_v1.2-13B-balanced-128.json"
Note: this should be with the quotes!
Other generation parameters can be set in ltx_video.yml file.